Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS refresh control doesn't show up after initial pull to refresh #26350

Closed
itsMapleLeaf opened this issue Sep 5, 2019 · 8 comments
Closed
Labels
Bug Platform: iOS iOS applications. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@itsMapleLeaf
Copy link

On iOS, the refresh control won't show if the refresh prop changes outside of a manual pull to refresh.

React Native version: 0.60.3
System:
    OS: macOS 10.14.6
    CPU: (4) x64 Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz
    Memory: 50.39 MB / 8.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 12.6.0 - /usr/local/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
    Android SDK:
      API Levels: 23, 24, 25, 26, 27, 28
      Build Tools: 23.0.1, 26.0.2, 26.0.3, 27.0.3, 28.0.1, 28.0.2, 28.0.3
      System Images: android-23 | Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom_64
, android-28 | Google APIs Intel x86 Atom
  IDEs:
    Android Studio: 3.1 AI-173.4907809
    Xcode: 10.3/10G8 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6 
    react-native: 0.60.3 => 0.60.3 
  npmGlobalPackages:
    react-native-cli: 2.0.1
    react-native-git-upgrade: 0.2.7

Steps To Reproduce

  1. Open this snack https://snack.expo.io/@kingdaro/scrollview-refresh-control-bug
  2. Tap "trigger refresh", the control will show up as expected
  3. Pull to refresh, the control shows up as expected
  4. Tap "trigger refresh" again, the control does not show up

Describe what you expected to happen:

The refresh control should always show if refreshing is true.

Snack, code example, screenshot, or link to a repository: https://snack.expo.io/@kingdaro/scrollview-refresh-control-bug

@react-native-bot react-native-bot added the Platform: iOS iOS applications. label Sep 5, 2019
@plimerence
Copy link

same issue

@stale
Copy link

stale bot commented Jan 7, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jan 7, 2020
@itsMapleLeaf
Copy link
Author

This still occurs

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Jan 7, 2020
@ca057
Copy link

ca057 commented Mar 23, 2020

The same issue occurs on my side. As far as I can see, this PR describes the same behavior and should fix it: #27397, so hopefully this will be fixed with the next release.

@stale
Copy link

stale bot commented Jun 21, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jun 21, 2020
@itsMapleLeaf
Copy link
Author

I ran the snack with expo 37, ran through the same steps, bug still happens. Unless 37 isn't on the latest RN version, this still happens

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Jun 21, 2020
@stale
Copy link

stale bot commented Sep 20, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Sep 20, 2020
@itsMapleLeaf
Copy link
Author

This appears to be fixed on expo v38! 🎉

@facebook facebook locked as resolved and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Platform: iOS iOS applications. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

4 participants