Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollResponder.scrollResponderScrollNativeHandleToKeyboard calls deprecated apis #28203

Closed
janicduplessis opened this issue Feb 28, 2020 · 8 comments
Assignees
Labels
Contributor A React Native contributor. Resolution: Locked This issue was locked by the bot.

Comments

@janicduplessis
Copy link
Contributor

Description:

ScrollResponder.scrollResponderScrollNativeHandleToKeyboard calls deprecated getInnerViewNode and getInnerViewRef. The warning recommends using innerViewRef, however I'm not sure how this could be done from ScrollResponder.

React Native version:

Master

Steps To Reproduce

Call scrollResponderScrollNativeHandleToKeyboard on a ScrollView responder instance.

Expected Results

No deprecation warnings.

Snack, code example, screenshot, or link to a repository:

N/A

@facebook-github-bot facebook-github-bot added the Contributor A React Native contributor. label Feb 28, 2020
@janicduplessis
Copy link
Contributor Author

cc @kacieb @TheSavior

@elicwhite
Copy link
Member

Thanks for flagging!

@elicwhite elicwhite assigned elicwhite and unassigned elicwhite Feb 29, 2020
@elicwhite
Copy link
Member

Hmm. I can't seem to assign @kacieb here. :-/

@hramos
Copy link
Contributor

hramos commented Feb 29, 2020

I think @kacieb might need to be added to the Facebook GitHub org

@hramos
Copy link
Contributor

hramos commented Feb 29, 2020

React Native version:

Master

❤️

@elicwhite
Copy link
Member

Yeah, @janicduplessis, it's super awesome that you are able to give this feedback to us so quickly by running on Master. It's so much better than finding out months later when people use a release.

@kacieb kacieb self-assigned this Feb 29, 2020
@janicduplessis
Copy link
Contributor Author

I mean I get to use cool things before everyone :D

@elicwhite
Copy link
Member

@kacieb removed these warnings to unblock 63 in this commit: 3246f68

She said she'll plan on relanding those warnings with the additional correct fixes at a later date.

@facebook facebook locked as resolved and limited conversation to collaborators Oct 1, 2021
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contributor A React Native contributor. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants