-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hermes debugging using Chrome DevTools not working since 118.0.5993.70 update #40994
Comments
|
https://bugs.chromium.org/p/chromium/issues/detail?id=1492849 There was a recent Chromium update that appended "?for_tabs" to the /json/list request and due to the implementation of InspectorProxy in metro-inspector-proxy@0.76.8 which is included with the current RN 0.72 boilerplate app the entire url from the pathname rightwards is being compared to the path-only variables PAGES_LIST_JSON_URL, and PAGES_LIST_JSON_URL_2. |
@116-7 well spotted! Note that the code for the inspector proxy has moved into the React Native repo. This is where we'd need to fix the routing logic: react-native/packages/dev-middleware/src/inspector-proxy/InspectorProxy.js Lines 97 to 100 in 3d5324a
|
It looks like Chrome is working on a fix on their side, which might be sufficient as far as old RN releases go: https://chromium-review.googlesource.com/c/chromium/src/+/4942670 |
Thanks! It's appearing now on iOS physical device after disabling it :) |
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This issue was closed because it has been stalled for 7 days with no activity. |
Description
After having Chrome automatically update to 118.0.5993.70 on MacOS Hermes debugging using DevTools as described in the React Native documentation is no longer working.
Testing with Chrome Beta 119.0.6045.21 reveals same issue.
Google's release note for 118.0.5993.70 include mention of a change "CVE-2023-5475: Inappropriate implementation in DevTools." However, the link to Google's bugtracker is not public so it might not be related.
Workaround possible by installing previous version of Chrome for Testing - 117.0.5938.149 as per instructions on Chromium's website.
npx @puppeteer/browsers install chrome@117.0.5938.149
React Native Version
0.72.6
Output of
npx react-native info
System:
OS: macOS 13.3.1
CPU: (8) arm64 Apple M1
Memory: 63.69 MB / 16.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 16.16.0
path: ~/.nvm/versions/node/v16.16.0/bin/node
Yarn:
version: 1.22.19
path: ~/.nvm/versions/node/v16.16.0/bin/yarn
npm:
version: 8.11.0
path: ~/.nvm/versions/node/v16.16.0/bin/npm
Watchman: Not Found
Managers:
CocoaPods:
version: 1.11.3
path: /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 22.4
- iOS 16.4
- macOS 13.3
- tvOS 16.4
- watchOS 9.4
Android SDK: Not Found
IDEs:
Android Studio: 2022.3 AI-223.8836.35.2231.10671973
Xcode:
version: 14.3.1/14E300c
path: /usr/bin/xcodebuild
Languages:
Java:
version: 11.0.15.1
path: /Library/Java/JavaVirtualMachines/jdk-11.0.15.1.jdk/Contents/Home/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.72.6
wanted: 0.72.6
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
Steps to reproduce
Snack, screenshot, or link to a repository
Screenshots showing issue as well as working example in all Chrome versions mentioned in description as well as both Android and iOS.
The text was updated successfully, but these errors were encountered: