Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require function without full commonjs leads to footguns #7663

Closed
calvinmetcalf opened this issue May 20, 2016 · 3 comments
Closed

require function without full commonjs leads to footguns #7663

calvinmetcalf opened this issue May 20, 2016 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@calvinmetcalf
Copy link

must like browserify and webpack react-native allows modularization via require, but unlike those other tools react-native does not provide the process global at all times (#7607), you can't require the built in node ones (browserify/commonjs-assert#21).

Some fixes

  • pull in those by default (via node-libs-browser)
  • give a better error message when one of those can't be found
@lacker
Copy link
Contributor

lacker commented Oct 21, 2016

I think this is a dupe, I am closing this issue

@lacker lacker closed this as completed Oct 21, 2016
@hawkrives
Copy link
Contributor

hawkrives commented Nov 11, 2016

@lacker Do you have a tracking bug for the dupe? I'd like to follow along.

EDIT: Some more searching brought me to #6253 and #1871. Apologies for the noise.

@lacker
Copy link
Contributor

lacker commented Nov 11, 2016

Sorry for not just pasting the link in the first place! I was probably brain dead after sorting through a huge list of issues that day.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 19, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants