Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsCodeLocation choice #821

Closed
nkt opened this issue Apr 12, 2015 · 3 comments
Closed

jsCodeLocation choice #821

nkt opened this issue Apr 12, 2015 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@nkt
Copy link
Contributor

nkt commented Apr 12, 2015

Why jsCodeLocation couldn't be defined by compiler, instead of programmer?
I've googled, XCode provide DEBUG macro, so we could do something like this:

#if DEBUG
  jsCodeLocation = [NSURL URLWithString:@"http://localhost:8081/index.ios.bundle"];
#else
  jsCodeLocation = [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
#endif

And also add compilation callback that would be update main.jsbundle.

@romanonthego
Copy link

it would also be extra nice to have npm build (or something like it) command provided by default.

@arthuralee
Copy link
Contributor

@romanonthego I gave your idea a try at #851!

@romanonthego
Copy link

thx, will totaly look into it.

@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants