Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepDiffer code triggers "Your code is broken" warnings about for...in Array iteration #870

Closed
ccheever opened this issue Apr 16, 2015 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ccheever
Copy link
Contributor

This code in Libraries/Utilities/differ/deepDiffer.js triggers the warning mentioned in #869

        for (var key in one) {
            if (deepDiffer(one[key], two[key])) {
                return true;
            }
        }
        for (var twoKey in two) {
            // The only case we haven't checked yet is keys that are in two but aren't
            // in one, which means they are different.
            if (one[twoKey] === undefined && two[twoKey] !== undefined) {
                return true;
            }
        }
@sophiebits
Copy link
Contributor

Dupe of #868, it looks like.

@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants