-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCTImageView / RCTImageLoader crash #9849
Comments
I'm getting similar crashes, I'm using RN 0.32.1, iOS only. |
do you know if it still repro on 0.33 ? |
I am seeing a similar crash in 0.33, iPhone 6s w/ iOS 9.3.5 Stack trace:
|
0.33 same issue #9882 |
Here is a crash report with 0.34: https://gist.github.com/joenoon/107f86251db049cad2377fc8201a475a |
The same issue in 0.34. Crash when calling [RCTNetworkTask cancel] |
Same here |
same same same here :( http://crashes.to/s/c55a4e38ab1 |
is it working on 0.31? an alternative for now might be to just downgrade. |
I am getting the same or similar error on rn 0.34. It's crashing when attempting to set cancelLoad to nil. Looks like cancelLoad may be called again while it's still cancelling. Thread 1Queue : com.apple.main-thread (serial)
|
@7kfpun yes, I think this bug don't exists in 0.31. I was thinking another workaround could be that you disable the cancellation feature on Image, I'm not sure how to easily do this though. Have to be careful if it doesn't create other bugs/leaks. |
May be related to commit 1418828? |
I think you are on to something @rumit91 |
This error accounts for most of our crashes also |
Not sure if this is related? #10274 |
@sattaman yes, I think there are bunch of issues raising the same problem |
anyone have tried if #10280 fixes this? |
same on 0.36 RC :( |
We believe this crash has been fixed in master (64dd140) and will be included with 0.36.0-rc.1, which will be published in a few hours if the automated tests pass. |
@jerson 0.35-rc-0 does not seem to contain a commit regarding this issue while one relevant commit was added to 0.35 - see the diff: 0f242a1...2519010 |
@davidgruebl it was tested on 0.36 RC yesterday http://crashes.to/s/411f88cc2bd today also tested in 0.35 and the same error :( now i will test in 0.36 RC1 |
@jerson thanks a lot for the info! Do you know which was the last react native version that was not affected by this? Also is there anything specific you do to reproduce this error? We haven't been able to reproduce when internally testing but just seeing this in production crash logs. |
@davidgruebl 0.36RC1 has solved the error :D , thank you very much, the bug appeared when displaying a list of big pictures like this and slid down very fast |
@jerson I have also reproduced the bug with a similar view, infinite scroll on lot of images :) @davidgruebl the bug start happening from 0.32 and is fixed from 0.36RC1 anyway, i'm glad it's fixed now, cheers! |
@davidgruebl same on 0.36.0-rc.1 |
unfortunately it's still happening to me as well :( |
Looks like this is still happening, #10433 is designated as the new issue to Subscribe to. |
I can confirm that the But, I can also confirm that the We upgraded our production app from 0.28.0 to 0.34.0 two weeks ago. After that, we experienced an enormous increase of crashes, so we decided to release a new app update with 0.36.0.rc.1 as soon as possible (hence the release candidate and not the stable version) as there were two promising commits in 0.35.0. and 0.36.0,rc.1 to fix this. After evaluating the crash rate of this crash after a week on production, we saw that the crash rate was reduced by 88% again, so it really helped. But still, a proper fix would be amazing. |
Can confirm @Aaang messadge, loks like issue was resolved but |
0.37.0 also crash |
I am on 0.37.0 and it also crashes. I am not rendering a big list of images, but I have a considerable data to be rendered on form of cards. If I slide the list too fast then the app crashes. Xcode says the exception was thrown on OSAtomicOr32Barrier(1, &cancelled); I hope this can be solved. I guess a way to "contour" this bug would be to limit the amount of items to be rendered? Because if I fetch less items into my list that doesn't seem to happen. |
Has [RCTImageLoader _loadImageOrDataWithURLRequest...] been fixed? Why is this issue closed? |
@IlyaRepo which version of react are you on? |
@myusuf3 0.34.0 |
0.38.0 also crash |
Issue Description
Few days ago we've release our application to AppStore and stared to receive quite a significant amount of crashes on Crashlytic related to RCTImageView, this is few of the crashes we getting, i can attach more if it is required:
We was not able to reproduce this issue on our side yet. But we loading a lot of images in our application (up to 300), can such amount affect it somehow?
It would be great if we cat get at least a hint where is the source of the issue =)
Additional Information
The text was updated successfully, but these errors were encountered: