Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaws of ScrollView sticky headers on Android #9929

Closed
nihgwu opened this issue Sep 15, 2016 · 3 comments
Closed

flaws of ScrollView sticky headers on Android #9929

nihgwu opened this issue Sep 15, 2016 · 3 comments
Assignees
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@nihgwu
Copy link
Contributor

nihgwu commented Sep 15, 2016

Thanks for @janicduplessis 's great work #9456 ,now we can stick the section headers on Android as on iOS, and I can remove my js workaround finally, I've test it and works really awesome with little flaws:

  1. The sticky headers will bounce if LayoutAnimation is configured, just try the ListViewPagingExample you can see that sticky headers will be affected by LayoutAnimation
  2. If renderHeader is set to ListView, and the header is a View component with no children, then the first item of the section rows will be stuck instead of the section header.
//good
renderHeader= () => {
  <View style={styles.header} ><View /></View>;
}
//bad
renderHeader= () => {
  <View style={styles.header} />;
}

but if you use Text or TouchableOpacity instead of View with no children, it works accurately too

@janicduplessis
Copy link
Contributor

Thanks a lot for testing this, gonna have a look at these issues.

@nihgwu
Copy link
Contributor Author

nihgwu commented Sep 15, 2016

@janicduplessis I've made a PR #9930 to add the ListViewPagingExample to the example list 😄

@nihgwu
Copy link
Contributor Author

nihgwu commented Sep 19, 2016

close as being resolved in #9957

@nihgwu nihgwu closed this as completed Sep 19, 2016
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants