Fix CameraRoll.getPhotos() crash on Android if device has a problematic video asset #21438
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed catching IOException to Exception Fixed issue facebook#20112
facebook-github-bot
added
the
CLA Signed
hramos
changed the title
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Oct 1, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
removed
Import Started
bartolkaruza
pushed a commit
to bartolkaruza/react-native-cameraroll
that referenced
this pull request
Feb 23, 2019
…ic video asset (#21438) Summary: Changed catching IOException to Exception Fixes #20112 Pull Request resolved: facebook/react-native#21438 Differential Revision: D10132453 Pulled By: hramos fbshipit-source-id: c68fa8c45d43e4f2d116b8084ffd731ad6bf5aec
bartolkaruza
pushed a commit
to bartolkaruza/react-native-cameraroll
that referenced
this pull request
Feb 24, 2019
…ic video asset (#21438) Summary: Changed catching IOException to Exception Fixes #20112 Pull Request resolved: facebook/react-native#21438 Differential Revision: D10132453 Pulled By: hramos fbshipit-source-id: c68fa8c45d43e4f2d116b8084ffd731ad6bf5aec
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
…ic video asset (facebook#21438) Summary: Changed catching IOException to Exception Fixes facebook#20112 Pull Request resolved: facebook#21438 Differential Revision: D10132453 Pulled By: hramos fbshipit-source-id: c68fa8c45d43e4f2d116b8084ffd731ad6bf5aec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed catching IOException to Exception
Fixes #20112
Test Plan:
This change will fix issue #20112.
Try download broken video (attached to issue #20112) and open on your Android device. In production build it will crash the app, on dev - you'll see the red screen with error "setDataSource failed: status - 0x80000000".
Expected behavior: broken video just will be ignored.
Release Notes:
[ANDROID] [BUGFIX][ReactAndroid/src/main/java/com/facebook/react/modules/camera/CameraRollManager.java] - Changed catching IOException to Exception. Fixed error "setDataSource failed: status - 0x80000000"