-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consoliate Android SDK version inside the Version Catalog #38949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Aug 11, 2023
This pull request was exported from Phabricator. Differential Revision: D48263891 |
Summary: I'm doing another pass of moving all the various version numbers of the Gradle Plugin inside the `[plugins]` section of the version catalog. Changelog: [Internal] [Changed] - Consolidate Gradle Plugin versions inside the version catalog Differential Revision: D48233147 fbshipit-source-id: e67d467bc194b6026ba6fca93c90d08d27b11123
Base commit: 4dbf5dc |
This pull request was exported from Phabricator. Differential Revision: D48263891 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 11, 2023
…8949) Summary: Pull Request resolved: facebook#38949 I've done another pass and moved all the compileSdk/minSdk/targetSdk and buildToolVersion in a single place so that we can easily bump one for all the projects. Changelog: [Internal] [Changed] - Consoliate Android SDK version inside the Version Catalog Reviewed By: cipolleschi Differential Revision: D48263891 fbshipit-source-id: 33754e4bdf85ad7e915c11fd951f3b5234a75f60
cortinico
force-pushed
the
export-D48263891
branch
from
August 11, 2023 14:39
c414812
to
1d7cdb3
Compare
This pull request was exported from Phabricator. Differential Revision: D48263891 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 11, 2023
…8949) Summary: Pull Request resolved: facebook#38949 I've done another pass and moved all the compileSdk/minSdk/targetSdk and buildToolVersion in a single place so that we can easily bump one for all the projects. Changelog: [Internal] [Changed] - Consoliate Android SDK version inside the Version Catalog Reviewed By: cipolleschi Differential Revision: D48263891 fbshipit-source-id: 8400d7ad6ea99848cbf00a5fb59e8ad312a816b9
cortinico
force-pushed
the
export-D48263891
branch
from
August 11, 2023 15:28
1d7cdb3
to
a88f1ce
Compare
…8949) Summary: Pull Request resolved: facebook#38949 I've done another pass and moved all the compileSdk/minSdk/targetSdk and buildToolVersion in a single place so that we can easily bump one for all the projects. Changelog: [Internal] [Changed] - Consoliate Android SDK version inside the Version Catalog Reviewed By: cipolleschi Differential Revision: D48263891 fbshipit-source-id: 84a5623869042b12bda0d3ee9e132d20fbc0e9d4
This pull request was exported from Phabricator. Differential Revision: D48263891 |
cortinico
force-pushed
the
export-D48263891
branch
from
August 11, 2023 15:45
a88f1ce
to
a878fcc
Compare
This pull request has been merged in d655d44. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I've done another pass and moved all the compileSdk/minSdk/targetSdk and buildToolVersion in a single place so that we can easily bump one for all the projects.
Changelog:
[Internal] [Changed] - Consoliate Android SDK version inside the Version Catalog
Reviewed By: cipolleschi
Differential Revision: D48263891