Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consoliate Android SDK version inside the Version Catalog #38949

Closed
wants to merge 2 commits into from

Conversation

cortinico
Copy link
Contributor

Summary:
I've done another pass and moved all the compileSdk/minSdk/targetSdk and buildToolVersion in a single place so that we can easily bump one for all the projects.

Changelog:
[Internal] [Changed] - Consoliate Android SDK version inside the Version Catalog

Reviewed By: cipolleschi

Differential Revision: D48263891

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 11, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48263891

Summary:
I'm doing another pass of moving all the various version numbers of the Gradle Plugin inside the `[plugins]` section of the version catalog.

Changelog:
[Internal] [Changed] - Consolidate Gradle Plugin versions inside the version catalog

Differential Revision: D48233147

fbshipit-source-id: e67d467bc194b6026ba6fca93c90d08d27b11123
@analysis-bot
Copy link

analysis-bot commented Aug 11, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,946,431 -22
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,540,138 -37
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 4dbf5dc
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48263891

cortinico added a commit to cortinico/react-native that referenced this pull request Aug 11, 2023
…8949)

Summary:
Pull Request resolved: facebook#38949

I've done another pass and moved all the compileSdk/minSdk/targetSdk and buildToolVersion in a single place so that we can easily bump one for all the projects.

Changelog:
[Internal] [Changed] - Consoliate Android SDK version inside the Version Catalog

Reviewed By: cipolleschi

Differential Revision: D48263891

fbshipit-source-id: 33754e4bdf85ad7e915c11fd951f3b5234a75f60
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48263891

cortinico added a commit to cortinico/react-native that referenced this pull request Aug 11, 2023
…8949)

Summary:
Pull Request resolved: facebook#38949

I've done another pass and moved all the compileSdk/minSdk/targetSdk and buildToolVersion in a single place so that we can easily bump one for all the projects.

Changelog:
[Internal] [Changed] - Consoliate Android SDK version inside the Version Catalog

Reviewed By: cipolleschi

Differential Revision: D48263891

fbshipit-source-id: 8400d7ad6ea99848cbf00a5fb59e8ad312a816b9
…8949)

Summary:
Pull Request resolved: facebook#38949

I've done another pass and moved all the compileSdk/minSdk/targetSdk and buildToolVersion in a single place so that we can easily bump one for all the projects.

Changelog:
[Internal] [Changed] - Consoliate Android SDK version inside the Version Catalog

Reviewed By: cipolleschi

Differential Revision: D48263891

fbshipit-source-id: 84a5623869042b12bda0d3ee9e132d20fbc0e9d4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48263891

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 11, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d655d44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants