JS: Upgrade to v8-compile-cache@^2.4.0 & eslint@^8.23.1 #39012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48336030 |
|
This pull request was exported from Phabricator. Differential Revision: D48336030 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Aug 14, 2023
Summary: Pull Request resolved: facebook#39012 Upgrades many of our projects to `v8-compile-cache@^2.4.0`, which includes [zertosh/v8-compile-cache#45](zertosh/v8-compile-cache#45). This fixes a very opaque segmentation fault when `v8-compile-cache` is used on Apple Silicon with mixed architecture modes. This also upgrades our projects to `eslint@^2.3.1`, which no longer has the dependency on an outdated version of `v8-compile-cache`. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D48336030 fbshipit-source-id: 5cf68aea0abed1a4081d0182f5fb9ef5b16511c5
yungsters
force-pushed
the
export-D48336030
branch
from
020039b
to
e210122
Compare
Base commit: 540c41b |
Summary: Pull Request resolved: facebook#39012 Upgrades many of our projects to `v8-compile-cache@^2.4.0`, which includes [zertosh/v8-compile-cache#45](zertosh/v8-compile-cache#45). This fixes a very opaque segmentation fault when `v8-compile-cache` is used on Apple Silicon with mixed architecture modes. This also upgrades our projects to `eslint@^2.3.1`, which no longer has the dependency on an outdated version of `v8-compile-cache`. Changelog: [Internal] Reviewed By: zertosh, NickGerleman Differential Revision: D48336030 fbshipit-source-id: 59e772d777e0775a9bd7c31218025cc2f34a1979
|
This pull request was exported from Phabricator. Differential Revision: D48336030 |
yungsters
force-pushed
the
export-D48336030
branch
from
e210122
to
14e1c55
Compare
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Aug 15, 2023
Summary: X-link: facebook/react-native#39012 Upgrades many of our projects to `v8-compile-cache@^2.4.0`, which includes [zertosh/v8-compile-cache#45](zertosh/v8-compile-cache#45). This fixes a very opaque segmentation fault when `v8-compile-cache` is used on Apple Silicon with mixed architecture modes. This also upgrades our projects to `eslint@^2.3.1`, which no longer has the dependency on an outdated version of `v8-compile-cache`. Changelog: [Internal] Reviewed By: zertosh, NickGerleman Differential Revision: D48336030 fbshipit-source-id: afa73d1f00bff826a8b76fa09949b9d35a97905b
|
This pull request has been merged in e637a33. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Upgrades many of our projects to
v8-compile-cache@^2.4.0, which includes zertosh/v8-compile-cache#45. This fixes a very opaque segmentation fault whenv8-compile-cacheis used on Apple Silicon with mixed architecture modes.This also upgrades our projects to
eslint@^2.3.1, which no longer has the dependency on an outdated version ofv8-compile-cache.Changelog:
[Internal]
Reviewed By: NickGerleman
Differential Revision: D48336030