Improve correctness of textTransform: capitalize #47219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65023821 |
Summary: We received reports that textTransform does not correctly match the web behaviour for capitalize, eg. capitalized characters should not be lowercased when using `capitalize`. Example input: 'hello WORLD', should become 'Hello WORLD'. Changelog: [General][Fixed] TextTransform: capitalize better reflects the web behaviour Reviewed By: NickGerleman Differential Revision: D65023821
javache
force-pushed
the
export-D65023821
branch
from
930764e to
f6573d7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65023821 |
|
This pull request has been merged in dc2000c. |
|
This pull request was successfully merged by @javache in dc2000c When will my fix make it into a release? | How to file a pick request? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We received reports that textTransform does not correctly match the web behaviour for capitalize.
Changelog: [General][Fixed] TextTransform: capitalize better reflects the web behaviour
Differential Revision: D65023821