-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transform
style processing for native
#124
Conversation
compressed-size: runtime library Size change: -0.02 kB
View unchanged
|
RSD benchmarks (for native)Base c10e6a9
Patch aeb43f5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
For simplicity (and to fix an internal edge case), we now translate all 'transform' values to the React Native object syntax. If a string 'transform' is ever passed to an Animated component, the animation will now work as expected. Close #123
RSD benchmarks (for native)Base c10e6a9
Patch b9b7894
|
{ | ||
"translateX": 1, | ||
}, | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The loss of translateY
here isn't technically a regression because the value is 1em
and wouldn't have worked before. (And the other transform types aren't supported on React Native). However we could look into supporting non-px units for translate at some point in the future
For simplicity (and to fix an internal edge case), we now translate all 'transform' values to the React Native object syntax. If a string 'transform' is ever passed to an Animated component, the animation will now work as expected.
Close #123