DevTools: Props editing interface tweaks (#16740)

* Fix DevTools new prop input size * Don't allow adding new values unless an overridePropsFn function has been provided. * Do not show empty 'none' label ablve a new prop input
facebook · Sep 10, 2019 · 2c98af7 · 2c98af7
1 parent 2ce5801
commit 2c98af7
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/packages/react-devtools-shared/src/devtools/views/Components/EditableValue.js b/packages/react-devtools-shared/src/devtools/views/Components/EditableValue.js
@@ -16,13 +16,15 @@ import {useEditableValue} from '../hooks';
 type OverrideValueFn = (path: Array<string | number>, value: any) => void;
 
 type EditableValueProps = {|
+  className?: string,
   dataType: string,
   initialValue: any,
   overrideValueFn: OverrideValueFn,
   path: Array<string | number>,
 |};
 
 export default function EditableValue({
+  className = '',
   dataType,
   initialValue,
   overrideValueFn,
@@ -74,7 +76,7 @@ export default function EditableValue({
     <Fragment>
       <input
         autoComplete="new-password"
-        className={isValid ? styles.Input : styles.Invalid}
+        className={`${isValid ? styles.Input : styles.Invalid} ${className}`}
         onChange={handleChange}
         onKeyDown={handleKeyDown}
         placeholder={placeholder}

diff --git a/packages/react-devtools-shared/src/devtools/views/Components/InspectedElementTree.css b/packages/react-devtools-shared/src/devtools/views/Components/InspectedElementTree.css
@@ -53,3 +53,7 @@
   display: flex;
   align-items: center;
 }
+
+.EditableValue {
+  min-width: 1rem;
+}
diff --git a/packages/react-devtools-shared/src/devtools/views/Components/InspectedElementTree.js b/packages/react-devtools-shared/src/devtools/views/Components/InspectedElementTree.js
@@ -82,7 +82,7 @@ export default function InspectedElementTree({
             </Button>
           )}
         </div>
-        {isEmpty && <div className={styles.Empty}>None</div>}
+        {isEmpty && !canAddEntries && <div className={styles.Empty}>None</div>}
         {!isEmpty &&
           (entries: any).map(([name, value]) => (
             <KeyValue
@@ -104,6 +104,7 @@ export default function InspectedElementTree({
             />
             :&nbsp;
             <EditableValue
+              className={styles.EditableValue}
               initialValue={''}
               overrideValueFn={handleNewEntryValue}
               path={[newPropName]}

diff --git a/packages/react-devtools-shared/src/devtools/views/Components/SelectedElement.js b/packages/react-devtools-shared/src/devtools/views/Components/SelectedElement.js
@@ -358,7 +358,7 @@ function InspectedElementView({
         inspectPath={inspectPropsPath}
         overrideValueFn={overridePropsFn}
         showWhenEmpty={true}
-        canAddEntries={true}
+        canAddEntries={typeof overridePropsFn === 'function'}
       />
       {type === ElementTypeSuspense ? (
         <InspectedElementTree