Skip to content

Commit

Permalink
[Re-land] Make prerendering always non-blocking (#31268)
Browse files Browse the repository at this point in the history
Follows #31238

___

This is a partial re-land of
#31056. We saw breakages surface
after the original land and had to revert. Now that they've been fixed,
let's try this again. This time we'll split up the commits to give us
more control of testing and rollout internally.

Original PR: #31056
Original Commit:
4c71025
Revert PR: #31080

Commit description:

> When a synchronous update suspends, and we prerender the siblings, the
prerendering should be non-blocking so that we can immediately restart
once the data arrives.
>
> This happens automatically when there's a Suspense boundary, because
we immediately commit the boundary and then proceed to a Retry render,
which are always concurrent. When there's not a Suspense boundary, there
is no Retry, so we need to take care to switch from the synchronous work
loop to the concurrent one, to enable time slicing.

Co-authored-by: Andrew Clark <git@andrewclark.io>

DiffTrain build for [6c4bbc7](6c4bbc7)
  • Loading branch information
jackpope committed Oct 15, 2024
1 parent 01ac93f commit 6ee7d9d
Show file tree
Hide file tree
Showing 23 changed files with 4,638 additions and 4,408 deletions.
2 changes: 1 addition & 1 deletion compiled-rn/VERSION_NATIVE_FB
Original file line number Diff line number Diff line change
@@ -1 +1 @@
19.0.0-native-fb-13411e45-20241014
19.0.0-native-fb-6c4bbc78-20241015
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<1d8dd9e8ce69a34a08cc90461cf3ab97>>
* @generated SignedSource<<346d6c2a30a0c9febc7fdeb632a0e1a4>>
*/

"use strict";
Expand Down Expand Up @@ -420,5 +420,5 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.0.0-native-fb-13411e45-20241014";
exports.version = "19.0.0-native-fb-6c4bbc78-20241015";
})();
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<2dd40d3277960a40fd61ad48c151ffa8>>
* @generated SignedSource<<ca0285c676912986569bcdebcd4c65cd>>
*/

"use strict";
Expand Down Expand Up @@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-native-fb-13411e45-20241014";
exports.version = "19.0.0-native-fb-6c4bbc78-20241015";
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<2dd40d3277960a40fd61ad48c151ffa8>>
* @generated SignedSource<<ca0285c676912986569bcdebcd4c65cd>>
*/

"use strict";
Expand Down Expand Up @@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.0.0-native-fb-13411e45-20241014";
exports.version = "19.0.0-native-fb-6c4bbc78-20241015";

Large diffs are not rendered by default.

Loading

0 comments on commit 6ee7d9d

Please sign in to comment.