From 7bcc687720bbb31873768399dd87c27d8c231011 Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Thu, 11 Aug 2022 15:24:56 +0200 Subject: [PATCH] Remove argument committedLanes from reappearLayoutEffects and recursivelyTraverseReappearLayoutEffects (#25080) --- .../react-reconciler/src/ReactFiberCommitWork.new.js | 11 ----------- .../react-reconciler/src/ReactFiberCommitWork.old.js | 11 ----------- 2 files changed, 22 deletions(-) diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.new.js b/packages/react-reconciler/src/ReactFiberCommitWork.new.js index 3f7417fc626d8..6a8b095f11a24 100644 --- a/packages/react-reconciler/src/ReactFiberCommitWork.new.js +++ b/packages/react-reconciler/src/ReactFiberCommitWork.new.js @@ -1099,7 +1099,6 @@ function commitLayoutEffectOnFiber( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); } else { @@ -2704,7 +2703,6 @@ function reappearLayoutEffects( finishedRoot: FiberRoot, current: Fiber | null, finishedWork: Fiber, - committedLanes: Lanes, // This function visits both newly finished work and nodes that were re-used // from a previously committed tree. We cannot check non-static flags if the // node was reused. @@ -2719,7 +2717,6 @@ function reappearLayoutEffects( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); // TODO: Check flags & LayoutStatic @@ -2730,7 +2727,6 @@ function reappearLayoutEffects( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); @@ -2772,7 +2768,6 @@ function reappearLayoutEffects( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); @@ -2792,7 +2787,6 @@ function reappearLayoutEffects( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); // TODO: Figure out how Profiler updates should work with Offscreen @@ -2805,7 +2799,6 @@ function reappearLayoutEffects( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); @@ -2825,7 +2818,6 @@ function reappearLayoutEffects( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); } @@ -2835,7 +2827,6 @@ function reappearLayoutEffects( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); break; @@ -2846,7 +2837,6 @@ function reappearLayoutEffects( function recursivelyTraverseReappearLayoutEffects( finishedRoot: FiberRoot, parentFiber: Fiber, - committedLanes: Lanes, includeWorkInProgressEffects: boolean, ) { // This function visits both newly finished work and nodes that were re-used @@ -2865,7 +2855,6 @@ function recursivelyTraverseReappearLayoutEffects( finishedRoot, current, child, - committedLanes, childShouldIncludeWorkInProgressEffects, ); child = child.sibling; diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.old.js b/packages/react-reconciler/src/ReactFiberCommitWork.old.js index b0e16e8ab2aeb..651414549b096 100644 --- a/packages/react-reconciler/src/ReactFiberCommitWork.old.js +++ b/packages/react-reconciler/src/ReactFiberCommitWork.old.js @@ -1099,7 +1099,6 @@ function commitLayoutEffectOnFiber( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); } else { @@ -2704,7 +2703,6 @@ function reappearLayoutEffects( finishedRoot: FiberRoot, current: Fiber | null, finishedWork: Fiber, - committedLanes: Lanes, // This function visits both newly finished work and nodes that were re-used // from a previously committed tree. We cannot check non-static flags if the // node was reused. @@ -2719,7 +2717,6 @@ function reappearLayoutEffects( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); // TODO: Check flags & LayoutStatic @@ -2730,7 +2727,6 @@ function reappearLayoutEffects( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); @@ -2772,7 +2768,6 @@ function reappearLayoutEffects( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); @@ -2792,7 +2787,6 @@ function reappearLayoutEffects( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); // TODO: Figure out how Profiler updates should work with Offscreen @@ -2805,7 +2799,6 @@ function reappearLayoutEffects( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); @@ -2825,7 +2818,6 @@ function reappearLayoutEffects( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); } @@ -2835,7 +2827,6 @@ function reappearLayoutEffects( recursivelyTraverseReappearLayoutEffects( finishedRoot, finishedWork, - committedLanes, includeWorkInProgressEffects, ); break; @@ -2846,7 +2837,6 @@ function reappearLayoutEffects( function recursivelyTraverseReappearLayoutEffects( finishedRoot: FiberRoot, parentFiber: Fiber, - committedLanes: Lanes, includeWorkInProgressEffects: boolean, ) { // This function visits both newly finished work and nodes that were re-used @@ -2865,7 +2855,6 @@ function recursivelyTraverseReappearLayoutEffects( finishedRoot, current, child, - committedLanes, childShouldIncludeWorkInProgressEffects, ); child = child.sibling;