Skip to content

Commit

Permalink
Merged changes from 4.0.5 -> 4.0.6 from DevTools fork
Browse files Browse the repository at this point in the history
  • Loading branch information
Brian Vaughn committed Aug 26, 2019
2 parents 13a93e7 + 4c15144 commit 9d4fd7a
Show file tree
Hide file tree
Showing 15 changed files with 28 additions and 18 deletions.
3 changes: 2 additions & 1 deletion packages/react-devtools-core/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-devtools-core",
"version": "4.0.5",
"version": "4.0.6",
"description": "Use react-devtools outside of the browser",
"license": "MIT",
"main": "./dist/backend.js",
Expand All @@ -24,6 +24,7 @@
"start:standalone": "cross-env NODE_ENV=development webpack --config webpack.standalone.js --watch"
},
"dependencies": {
"es6-symbol": "^3",
"shell-quote": "^1.6.1",
"ws": "^7"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/react-devtools-extensions/chrome/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"manifest_version": 2,
"name": "React Developer Tools",
"description": "Adds React debugging tools to the Chrome Developer Tools.",
"version": "4.0.5",
"version_name": "4.0.5",
"version": "4.0.6",
"version_name": "4.0.6",

"minimum_chrome_version": "49",

Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-extensions/firefox/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"manifest_version": 2,
"name": "React Developer Tools",
"description": "Adds React debugging tools to the Firefox Developer Tools.",
"version": "4.0.5",
"version": "4.0.6",

"applications": {
"gecko": {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-extensions/popups/deadcode.html
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@
</p>
<hr />
<p>
Open the developer tools, and the React tab will appear to the right.
Open the developer tools, and "Components" and "Profiler" tabs will appear to the right.
</p>
2 changes: 1 addition & 1 deletion packages/react-devtools-extensions/popups/development.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@
</p>
<hr />
<p>
Open the developer tools, and the React tab will appear to the right.
Open the developer tools, and "Components" and "Profiler" tabs will appear to the right.
</p>
2 changes: 1 addition & 1 deletion packages/react-devtools-extensions/popups/outdated.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@
</p>
<hr />
<p>
Open the developer tools, and the React tab will appear to the right.
Open the developer tools, and "Components" and "Profiler" tabs will appear to the right.
</p>
2 changes: 1 addition & 1 deletion packages/react-devtools-extensions/popups/production.html
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@
<p>
<b>This page is using the production build of React. &#x2705;</b>
<br />
Open the developer tools, and the React tab will appear to the right.
Open the developer tools, and "Components" and "Profiler" tabs will appear to the right.
</p>
2 changes: 1 addition & 1 deletion packages/react-devtools-extensions/popups/unminified.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@
</p>
<hr />
<p>
Open the developer tools, and the React tab will appear to the right.
Open the developer tools, and "Components" and "Profiler" tabs will appear to the right.
</p>
8 changes: 5 additions & 3 deletions packages/react-devtools-extensions/src/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ import DevTools from 'react-devtools-shared/src/devtools/views/DevTools';
const LOCAL_STORAGE_SUPPORTS_PROFILING_KEY =
'React::DevTools::supportsProfiling';

const isChrome = getBrowserName() === 'Chrome';

let panelCreated = false;

// The renderer interface can't read saved component filters directly,
Expand Down Expand Up @@ -126,7 +128,7 @@ function createPanelIfReactLoaded() {

store = new Store(bridge, {
isProfiling,
supportsReloadAndProfile: getBrowserName() === 'Chrome',
supportsReloadAndProfile: isChrome,
supportsProfiling,
});
store.profilerStore.profilingData = profilingData;
Expand Down Expand Up @@ -232,7 +234,7 @@ function createPanelIfReactLoaded() {
let needsToSyncElementSelection = false;

chrome.devtools.panels.create(
'⚛ Components',
isChrome ? '⚛ Components' : 'Components',
'',
'panel.html',
extensionPanel => {
Expand Down Expand Up @@ -262,7 +264,7 @@ function createPanelIfReactLoaded() {
);

chrome.devtools.panels.create(
'⚛ Profiler',
isChrome ? '⚛ Profiler' : 'Profiler',
'',
'panel.html',
extensionPanel => {
Expand Down
6 changes: 4 additions & 2 deletions packages/react-devtools-inline/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-devtools-inline",
"version": "4.0.5",
"version": "4.0.6",
"description": "Embed react-devtools within a website",
"license": "MIT",
"main": "./dist/backend.js",
Expand All @@ -20,7 +20,9 @@
"prepublish": "yarn run build",
"start": "cross-env NODE_ENV=development webpack --config webpack.config.js --watch"
},
"dependencies": {},
"dependencies": {
"es6-symbol": "^3"
},
"devDependencies": {
"@babel/core": "^7.1.6",
"@babel/plugin-proposal-class-properties": "^7.1.0",
Expand Down
5 changes: 4 additions & 1 deletion packages/react-devtools-shared/src/backend/renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -2074,7 +2074,10 @@ export function attach(
let fiber = findCurrentFiberUsingSlowPathById(id);
if (fiber !== null) {
instance = fiber.stateNode;
style = fiber.memoizedProps.style;

if (fiber.memoizedProps !== null) {
style = fiber.memoizedProps.style;
}
}

return {instance, style};
Expand Down
1 change: 1 addition & 0 deletions packages/react-devtools-shared/src/hydration.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// @flow

import Symbol from 'es6-symbol';
import {
isElement,
typeOf,
Expand Down
1 change: 1 addition & 0 deletions packages/react-devtools-shared/src/utils.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// @flow

import Symbol from 'es6-symbol';
import LRU from 'lru-cache';
import {
TREE_OPERATION_ADD,
Expand Down
4 changes: 2 additions & 2 deletions packages/react-devtools/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-devtools",
"version": "4.0.5",
"version": "4.0.6",
"description": "Use react-devtools outside of the browser",
"license": "MIT",
"repository": {
Expand All @@ -27,7 +27,7 @@
"electron": "^5.0.0",
"ip": "^1.1.4",
"minimist": "^1.2.0",
"react-devtools-core": "4.0.5",
"react-devtools-core": "4.0.6",
"update-notifier": "^2.1.0"
}
}
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4551,7 +4551,7 @@ es6-set@~0.1.5:
es6-symbol "3.1.1"
event-emitter "~0.3.5"

es6-symbol@3.1.1, es6-symbol@^3.1.1, es6-symbol@~3.1.1:
es6-symbol@3.1.1, es6-symbol@^3, es6-symbol@^3.1.1, es6-symbol@~3.1.1:
version "3.1.1"
resolved "https://registry.yarnpkg.com/es6-symbol/-/es6-symbol-3.1.1.tgz#bf00ef4fdab6ba1b46ecb7b629b4c7ed5715cc77"
integrity sha1-vwDvT9q2uhtG7Le2KbTH7VcVzHc=
Expand Down

0 comments on commit 9d4fd7a

Please sign in to comment.