Skip to content

Commit

Permalink
Build: make version in build artifacts match (#26329)
Browse files Browse the repository at this point in the history
Some build artifacts contain multiple version strings. It seems like an
oversight to me that this `.replace` call just replaces the one that
happens to be first.
  • Loading branch information
kassens authored Mar 6, 2023
1 parent 88313ff commit ba353a5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/rollup/build-all-release-channels.js
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ function updatePlaceholderReactVersionInCompiledArtifacts(

for (const artifactFilename of artifactFilenames) {
const originalText = fs.readFileSync(artifactFilename, 'utf8');
const replacedText = originalText.replace(
const replacedText = originalText.replaceAll(
PLACEHOLDER_REACT_VERSION,
newVersion
);
Expand Down

0 comments on commit ba353a5

Please sign in to comment.