Skip to content

Commit

Permalink
[Fizz] Stop publishing external-runtime to stable channel (#28796)
Browse files Browse the repository at this point in the history
The external runtime is not vetted for stability yet. We should stop
publishing it with our stable build
  • Loading branch information
gnoff authored Apr 9, 2024
1 parent 67ff96e commit bf40b02
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/shared/ReactFeatureFlags.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export const enableUseEffectEventHook = __EXPERIMENTAL__;
// Test in www before enabling in open source.
// Enables DOM-server to stream its instruction set as data-attributes
// (handled with an MutationObserver) instead of inline-scripts
export const enableFizzExternalRuntime = true;
export const enableFizzExternalRuntime = __EXPERIMENTAL__;

export const alwaysThrottleRetries = true;

Expand Down
2 changes: 1 addition & 1 deletion scripts/rollup/bundles.js
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ const bundles = [

/******* React DOM Fizz Server External Runtime *******/
{
bundleTypes: [BROWSER_SCRIPT],
bundleTypes: __EXPERIMENTAL__ ? [BROWSER_SCRIPT] : [],
moduleType: RENDERER,
entry: 'react-dom/unstable_server-external-runtime',
outputPath: 'unstable_server-external-runtime.js',
Expand Down
9 changes: 8 additions & 1 deletion scripts/rollup/packaging.js
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,14 @@ function filterOutEntrypoints(name) {
// Let's remove it.
files.splice(i, 1);
i--;
unlinkSync(`build/node_modules/${name}/${filename}`);
try {
unlinkSync(`build/node_modules/${name}/${filename}`);
} catch (err) {
// If the file doesn't exist we can just move on. Otherwise throw the halt the build
if (err.code !== 'ENOENT') {
throw err;
}
}
changed = true;
// Remove it from the exports field too if it exists.
if (exportsJSON) {
Expand Down

0 comments on commit bf40b02

Please sign in to comment.