You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fiber is not reentrant but other renderers might be. The synchronous server renderer is atm.
We should add tests for warnings between renderers, such as calling a server-render from within a client render, and update the set/reset callsites to use push/pop instead to account for that.
The text was updated successfully, but these errors were encountered:
I didn't end up adding push/pop to DebugFrame itself because relying on it would break ReactDOMServer 16.X + React 16.0, for example.
We can reconsider this later, but for now I'm keeping track of reentrancy in ReactDOMServer itself, and restore the outer stack implementation on exit from the outermost ReactDOMServer call.
I will later probably do something similar for cross-renderer calls on the client (except it's simpler because there's no re-entrancy within one renderer instance).
I realized that the refactor to use ReactDebugCurrentFrame as a decoupled stack frame for error messages is not reentrant: https://github.com/facebook/react/pull/10105/files#r127573520
Fiber is not reentrant but other renderers might be. The synchronous server renderer is atm.
We should add tests for warnings between renderers, such as calling a server-render from within a client render, and update the set/reset callsites to use push/pop instead to account for that.
The text was updated successfully, but these errors were encountered: