-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-dom/server: renderToString fails with array type children #10212
Comments
Yep, this is a known limitation and will be fixed before 16. Would you be interested in implementing this? |
I'm not quite sure how yet. I'll go through the code and give it a shot |
hi,@gaearon,I am interested in implementing this. |
If either of you could try and send a PR that would be great! The code is in ReactPartialRenderer. |
@gaearon @tushar-singh , I has been completed, I will send PR. you can view the online demo: |
Cool, happy to review a PR. |
Fixed by #10221. |
I don't know why I am the only one, but this is still happening for me. Getting this with Version v16.1.1. |
File a new issue with a reproducing case please. |
It's hard to keep track of problems in closed issues so I'll lock this one. |
React 16 alpha allows returning array in render function but server renderer expects children to always be react elements
source
Fiddle: https://jsfiddle.net/84v837e9/160/
react@16.0.0-alpha.13
The text was updated successfully, but these errors were encountered: