-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing onAnimationStart/onAnimationEnd event handlers #1196
Comments
Take a look at https://github.com/facebook/react/blob/master/src/addons/transitions/ReactTransitionEvents.js which is currently listening for the right events. |
Yah: I've seen that file before. To be clear; are you suggesting that I use that strategy to handle multiple browsers or to use that component directly? |
👍 to add native support for @tichris0: In the meantime, I solved it as follows: TransitionEvents = require 'react/lib/ReactTransitionEvents'
module.exports = React.createClass
displayName: 'Component'
# ...
componentDidMount: ->
# HACK: Manually support `animationEnd` event
# See: http://git.io/dfdd1Q
if @props.onAnimationEnd
TransitionEvents.addEndEventListener @getDOMNode(),
@props.onAnimationEnd
render: ->
# ...
# Invoke as follows:
Component
onAnimationEnd: @handleAnimationEnd
# ... |
Hi, would love a status update on this, any targeted fix version or date? |
The support for them was merged into master in #6005 a few days ago. Stay tuned! |
React currently doesn't handle the aforementioned 2 events. I have a patch that works for webkit only; but more work needs to be done to make it work under all browsers until they support the standard CSS tags.
The text was updated successfully, but these errors were encountered: