Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debugRenderPhaseSideEffects behavior #12046

Closed
2 tasks done
bvaughn opened this issue Jan 18, 2018 · 0 comments
Closed
2 tasks done

Update debugRenderPhaseSideEffects behavior #12046

bvaughn opened this issue Jan 18, 2018 · 0 comments
Assignees

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Jan 18, 2018

Follow up item for PR #12028

Within the context of an async tree, we should double-invoke the following methods:

  • constructor
  • render
  • static getDerivedStateFromProps
  • setState updater functions

The current implementation of debugRenderPhaseSideEffects is to also double-invoke several additional methods (eg will-mount, will-update, sCU, etc). This behavior should be removed.

We should also add a dev-warning if we detect any components within an async tree that contain the following methods:

  • componentWillMount (or UNSAFE_componentWillMount)
  • componentWillReceiveProps (or UNSAFE_componentWillReceiveProps)
  • componentWillUpdate (or UNSAFE_componentWillUpdate)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant