-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use of Proxy for events in development #12171
Comments
(In strict mode, we can get an error something like this.)
It's a trade off :) |
I think it's safe to assume most React users run in strict mode by now. |
You'd still run into the initial concern in #5853 that Sealing would prevent extension after |
Can we rewrite the check to just verify the existing fields are not used when we take it from the pool? I just want to get rid of the proxy there. It's annoying. |
I'll work on to verify that the change makes sense. |
If you are using an ES Proxy and the properties don't show up it sounds like a debugger bug. |
I don't think so. Trying to enumerate them is potentially side-effectful, it wouldn't be safe for the debugger to do. |
Only if there is a |
Fixed by #13225. |
I think maybe we should revert #5947.
People already think
proxyEvent
is some kind of an API: #12169.It's also annoying to view in the debugger because none of the properties show up.
Instead, we could seal the event object or something like that.
The text was updated successfully, but these errors were encountered: