Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation of the release process #12337

Merged
merged 3 commits into from
Apr 16, 2018
Merged

Fix documentation of the release process #12337

merged 3 commits into from
Apr 16, 2018

Conversation

FlXlT
Copy link
Contributor

@FlXlT FlXlT commented Mar 6, 2018 •
edited
Loading

Adjusted some grammar in the scripts/release/README.md file.

  • Adjusted title to infer that there are different kinds of release scripts
  • The first sentence infers that there is one release script. However, it seems that the release process includes two scripts rather than being a script on its own.
  • Officially, and also confirmed on the homepage readme, the npm logo and name are with lowercase letters.
  • Some abbreviations were missing punctuation.

@gaearon gaearon merged commit 1e97a71 into facebook:master Apr 16, 2018
This was referenced Apr 17, 2018
Closed
Closed
This was referenced Apr 19, 2018
Closed
Closed
Closed
Closed
rhagigi pushed a commit to rhagigi/react that referenced this pull request Apr 19, 2018
@FlXlT @rhagigi
Fix documentation of the release process (facebook#12337)
a9b0f79 
* Adusted grammar in release script readme.

* Adjusts title and explanation about the release process.
@jaramir jaramir mentioned this pull request Apr 20, 2018
Closed
@renovate renovate bot mentioned this pull request Apr 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Humberd Humberd Humberd approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FlXlT @Humberd @gaearon @facebook-github-bot @dalderliesten