Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DEV-only warnings from shallow renderer #12432

Closed
bvaughn opened this issue Mar 22, 2018 · 0 comments · Fixed by #12433
Closed

Remove DEV-only warnings from shallow renderer #12432

bvaughn opened this issue Mar 22, 2018 · 0 comments · Fixed by #12433
Assignees
@bvaughn

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Mar 22, 2018 •
edited
Loading

For consideration.

These warnings are already covered by renderers based on react-reconciler. Maybe we don't gain that much by mirroring them in the shallow renderer? Maybe it's not worth the added complexity? Particularly with more complicated warnings like the ones being added for #12419 and #12404.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvaughn bvaughn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed dev warnings from shallow renderer. bvaughn/react
1 participant
@bvaughn