Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crossOrigin attribute should be lowercased in rendered #14829

Closed
upsuper opened this issue Feb 11, 2019 · 2 comments
Closed

crossOrigin attribute should be lowercased in rendered #14829

upsuper opened this issue Feb 11, 2019 · 2 comments
Assignees

Comments

@upsuper
Copy link

upsuper commented Feb 11, 2019

Do you want to request a feature or report a bug?

A bug.

What is the current behavior?

When using

<img crossOrigin="anonymous"/>

it is rendered as

<img crossOrigin="anonymous">

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:

https://jsfiddle.net/upsuper/y9q5fp3t/

What is the expected behavior?

crossOrigin should be lower-cased when rendering.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

Latest version.

(This is basically just #14216, but that was closed because HTML attribute name is case-insensitive. However, this is still a problem for SVG, since SVG attribute name is case-sensitive, and thus crossOrigin doesn't work.)

@aweary
Copy link
Contributor

aweary commented Feb 12, 2019

Thanks for bringing this up, we already special case tabIndex for SVG so we should do the same here.

@gaearon
Copy link
Collaborator

gaearon commented Feb 14, 2019

Fixed in 16.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants