-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevTools: Should be able to add a prop that is not yet set #16484
Comments
I like the "+" button. I think we should probably use FWIW, Style editor already does this (and has an "invalid" style for things that can't be parsed, and single quotation mark handling) so we should use it for prior art. |
Awesome! Thanks @bvaughn. I'm on it 🚀 |
By the way, it sounds like this work highly overlaps with #16476. Just mentioning that to make sure you're aware :) |
@bvaughn What do you think of this style of editing props? It's aligned with the style editor. 😄 If you are cool with this I can start preparing the branch. 🎉 👇 Number -> String -> null -> Number 👇 |
That looks really nice. Let's do it! |
Cool! I'll try and get it finished by the end of the week. I'll ping you when it's done. |
Update: Almost done! Just finishing up some styling tweaks. PR should be open tomorrow :) |
Right now I can inspect a component and edit its props but I could not find a way to add a new prop that wasn't already set.
Originally reported by @steveluscher via bvaughn/react-devtools-experimental#300
The text was updated successfully, but these errors were encountered: