Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools: Profiler: Save profile does nothing on Firefox #16527

Closed
deadmau6 opened this issue Aug 21, 2019 · 2 comments · Fixed by #16612
Closed

DevTools: Profiler: Save profile does nothing on Firefox #16527

deadmau6 opened this issue Aug 21, 2019 · 2 comments · Fixed by #16612

Comments

@deadmau6
Copy link

Hi, long time user, first time issuer.

I think I found a bug with the Profiler component. When I click on the Save profile... button at the top nothing happens and there appears to be no new files in my Downloads folder. I think it might be silently failing and that's why I am not getting any response. Has anyone else ran into this issue?

Another thing I would like to mention is that I haven't looked through all of the documentation material about the new Profiler. I only read this introductory blog post, so if this issue is addressed elsewhere I apologize and also request the source to that solution.

Thank you for your time!

Versions:

  • React DevTools 4.0.5
  • Firefox: 68.0.2(64-bit)
  • Ubuntu: 18.04
@hristo-kanchev
Copy link
Contributor

hristo-kanchev commented Aug 26, 2019

It seems that this is happening because of the createElement call in the downloadFile util function.

I'll investigate this further.

@hristo-kanchev
Copy link
Contributor

I fixed the issue. I'll open a PR later today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants