-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: react-devtools error when KEY and CERT are provided, SSL not usable #19338
Comments
I was able to fix this by changing line 149 in my local copy to: |
cc @ittaibaratz Interested in picking this one up? OR @digicide, want to submit a fix? :) |
@digicide's fix sounds good to me - I'll submit a PR shortly. |
Looks like a PR already got submitted #19336 |
Actually, there's already a PR that fixes a slightly different way - https://github.com/facebook/react/pull/19336/files |
Sorry for the inconvenience here. Will probably publish a release in the morning. |
Version 4.8.2 has just been published to NPM with a fix for this issue. |
SSL is not usable because key and cert options are added to an uninitialized options object.
Line 149 of react-devtools/app.html reads 'let options;'
Line 154 and 155 begin with 'options.cert = …'
In every case, this throws an error and enters the catch block.
React version: 16.5.2
react-devtools version: 4.8.1
Steps To Reproduce
KEY=react-devtools-ssl-key.pem CERT=react-devtools-ssl-cert.pem ./node_modules/react-devtools/bin.js
Regardless of whether the key and cert are valid, the error "Cannot set property 'key' of undefined" is thrown.
The text was updated successfully, but these errors were encountered: