Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a toggle for Boolean props in DevTools #19662

Closed
gaearon opened this issue Aug 20, 2020 · 5 comments · Fixed by #19714
Closed

Add a toggle for Boolean props in DevTools #19662

gaearon opened this issue Aug 20, 2020 · 5 comments · Fixed by #19714
Labels
Component: Developer Tools good first issue (taken) Type: Enhancement

Comments

@gaearon
Copy link
Collaborator

gaearon commented Aug 20, 2020

We previously had a feature where Boolean props would show a checkbox to the left of them in the DevTools pane. It was removed when the JSON editor was added, but I think we should add it back. It should work like this:

  1. If the value is a boolean, the checkbox should show up to the left of true / false value
  2. If it's no longer a boolean (e.g. gets edited manually), the checkbox disappears
@gaearon gaearon added Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Component: Developer Tools good first issue Type: Enhancement and removed Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Aug 20, 2020
@mdaj06
Copy link
Contributor

mdaj06 commented Aug 20, 2020

I could take this up!

@gaearon
Copy link
Collaborator Author

gaearon commented Aug 20, 2020 •
edited
Loading

Sounds good!

@mdaj06
Copy link
Contributor

mdaj06 commented Aug 25, 2020

I have come up with a possible fix, could you suggest how i could test the changes made to dev-tools locally?

@gaearon
Copy link
Collaborator Author

gaearon commented Aug 25, 2020

Does this help?
https://github.com/facebook/react/tree/master/packages/react-devtools-inline#local-development

@mdaj06
Copy link
Contributor

mdaj06 commented Aug 25, 2020

yup! looks like it can help. Thanks!

@mdaj06 mdaj06 mentioned this issue Aug 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Developer Tools good first issue (taken) Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add checkbox toggle for boolean values mdaj06/react
2 participants
@gaearon @mdaj06