Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Async Stack Tagging API support #25742

Closed
Jack-Works opened this issue Nov 25, 2022 · 7 comments
Closed

Add Async Stack Tagging API support #25742

Jack-Works opened this issue Nov 25, 2022 · 7 comments
Labels
Resolution: Stale Automatically closed due to inactivity Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@Jack-Works
Copy link
Contributor

Chrome recently shipped Async Stack Tagging API that can significantly improve the debug stack.

Angular is already using it. See https://developer.chrome.com/blog/devtools-better-angular-debugging/#the-async-stack-tagging-api

image

Since React is using time slicing to split the task, it is not convenient to debug why the update is triggered. If React supports Async Stack Tagging API, it will be much easier to find out why an update is triggered.

@Jack-Works Jack-Works added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Nov 25, 2022
@Jack-Works

This comment was marked as outdated.

@0xdevalias
Copy link
Contributor

0xdevalias commented Dec 1, 2023

@Jack-Works Curious if you ever made further progress on this? It would be super useful.

Further resources:

See also:

@Jack-Works
Copy link
Contributor Author

@Jack-Works Curious if you ever made further progress on this? It would be super useful.

Sorry No, I'm working on other open-source projects these days. I'm still willing to implement them, but only when the React team says they accept the contribution of this feature otherwise I am afraid this will be rejected for some reasons.

@0xdevalias
Copy link
Contributor

0xdevalias commented Dec 2, 2023

I'm still willing to implement them, but only when the React team says they accept the contribution of this feature otherwise I am afraid this will be rejected for some reasons.

@Jack-Works nods that's totally understandable.

Do you have your test branch where you started implementing the above pushed anywhere? It might be a useful resource for others if they wanted to take up this in future.

@reaktivo
Copy link

reaktivo commented Feb 9, 2024

Relying on Async Stack Tagging would be absolutely a blessing when debugging React :|

Copy link

github-actions bot commented May 9, 2024

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label May 9, 2024
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Stale Automatically closed due to inactivity Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Development

No branches or pull requests

3 participants