Skip SelectEventPlugin extraction if no listeners #3639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are no listeners for
onSelect
yet, do not extract events. This way we can avoid issues where listeners have been set up for some event dependencies forSelectEventPlugin
, but not all.For instance, if
topMouseDown
has been registered but nottopMouseUp
, event extraction will set themouseDown
flag to true but never unset it. This leads to bugs whenonSelect
is registered and should be firing during normal key behavior. Since notopMouseUp
has yet occurred to unset the flag,onSelect
fails to fire.