Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cite attribute in blockquote element. #6084

Closed
Primajin opened this issue Feb 22, 2016 · 6 comments
Closed

Allow cite attribute in blockquote element. #6084

Primajin opened this issue Feb 22, 2016 · 6 comments

Comments

@Primajin
Copy link

cite is currently only supported as element, not as attribute in blockquote.
Since it is unknown to react it's thrown away on render.

cite
A URL that designates a source document or message for the information quoted. This attribute is intended to point to information explaining the context or the reference for the quote.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/blockquote

@AprilArcus
Copy link
Contributor

I'd like to take this!

@zpao
Copy link
Member

zpao commented Feb 23, 2016

It's yours @AprilArcus! Let me know if you have any questions.

@jimfb jimfb closed this as completed in 39c597f Feb 24, 2016
@Primajin
Copy link
Author

Cool! 👍

@jasonrundell
Copy link

Can we get this into a PR pretty please? :o)

@Primajin
Copy link
Author

Primajin commented Jun 4, 2019

Umm @jasonrundell this was merged 3 years ago already...

@jasonrundell
Copy link

@Primajin my apologies. I came across this from a Google search after using cite in blockquote in React 16.8.6 was throwing an error for me at build time. I'll have to dig deeper into the cause.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants