Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight element that failed checksum #7300

Closed
davidgilbertson opened this issue Jul 19, 2016 · 1 comment
Closed

Highlight element that failed checksum #7300

davidgilbertson opened this issue Jul 19, 2016 · 1 comment

Comments

@davidgilbertson
Copy link
Contributor

At the moment, when the server-rendered markup doesn't match the client-rendered markup, a big red error is shown, but it can be difficult/impossible to locate the element where this occurred.

Would something that logged the offending element to the console be considered as a pull request?

react-diff

master...davidgilbertson:log-checksum-failed-element

@gaearon
Copy link
Collaborator

gaearon commented Oct 4, 2017

This sounds interesting. We don't do checksum validation anymore in 16 but still need to report differences. I mentioned this approach in #10085 so let's keep the discussion there.

@gaearon gaearon closed this as completed Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants