Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9627] Fix create-react-class isMounted ordering issue #9638

Merged
merged 2 commits into from
Jun 12, 2017

Conversation

mridgway
Copy link
Contributor

@mridgway mridgway commented May 9, 2017

Split the IsMountedMixin in two so that the __isMounted flag is set to false after componentWillUnmount is executed in mixins and the component.

Fixes #9627

@acdlite I wasn't sure how to build the create-react-class.js and create-react-class.min.js. yarn build did not seem to touch those files.

Split the IsMountedMixin in two so that the __isMounted flag is set to false after componentWillUnmount is executed in mixins and the component.
@gaearon
Copy link
Collaborator

gaearon commented May 10, 2017

I wasn't sure how to build the create-react-class.js and create-react-class.min.js. yarn build did not seem to touch those files.

The sad part is there's no automated way to do it. 😞
I built it with several by hand manipulations last time, and it was pretty error-prone.

I can do it again, but I'd like to make sure we did all changes we want to first.

@flarnie flarnie self-requested a review May 24, 2017 13:59
@flarnie flarnie mentioned this pull request May 24, 2017
49 tasks
@gaearon
Copy link
Collaborator

gaearon commented Jun 12, 2017

Looks great. Flow failure seems unrelated—if it continues after merge I'll investigate. Thanks!

@gaearon gaearon merged commit 61e8ee7 into facebook:15.6-dev Jun 12, 2017
@gaearon
Copy link
Collaborator

gaearon commented Jun 12, 2017

(I confirmed the test replicates 15.4.x behavior)

@mridgway mridgway deleted the fixIsMounted branch June 12, 2017 19:43
nhunzaker pushed a commit to nhunzaker/react that referenced this pull request Jun 13, 2017
…book#9638)

* [facebook#9627] Fix create-react-class isMounted ordering issue

Split the IsMountedMixin in two so that the __isMounted flag is set to false after componentWillUnmount is executed in mixins and the component.

* Revert changes to integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants