Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix host context issues around EventComponents and EventTargets #15284

Merged
merged 4 commits into from
Apr 1, 2019
Merged

Fix host context issues around EventComponents and EventTargets #15284

merged 4 commits into from
Apr 1, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Apr 1, 2019 •
edited
Loading

This PR adds more support for host context with EventComponent and EventTarget fiber work types along with tests that validate this works during the unwind phase (for example, when an error occurs). This also adds support for pushing event host context in begin phase.

@sizebot
Copy link

sizebot commented Apr 1, 2019 •
edited
Loading

ReactDOM: size: 0.0%, gzip: -0.0%

Details of bundled changes.

Comparing: 9444a54...b8a1eea

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 813.79 KB 814.12 KB 184.28 KB 184.32 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 105.12 KB 105.15 KB 33.98 KB 33.98 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.1% 108.1 KB 108.13 KB 34.63 KB 34.61 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 808.18 KB 808.51 KB 182.67 KB 182.73 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 105.1 KB 105.13 KB 33.48 KB 33.48 KB NODE_PROD
react-dom.profiling.min.js 0.0% 0.0% 108.2 KB 108.23 KB 34.08 KB 34.08 KB NODE_PROFILING
ReactDOM-dev.js 0.0% 0.0% 832.93 KB 833.25 KB 184.3 KB 184.37 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.1% 0.0% 331.38 KB 331.56 KB 61.04 KB 61.06 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% 0.0% 337.76 KB 337.95 KB 62.39 KB 62.41 KB FB_WWW_PROFILING
react-dom-unstable-fire.development.js 0.0% 0.0% 814.13 KB 814.47 KB 184.42 KB 184.47 KB UMD_DEV
react-dom-unstable-fire.production.min.js 0.0% -0.0% 105.14 KB 105.17 KB 33.99 KB 33.98 KB UMD_PROD
react-dom-unstable-fire.profiling.min.js 0.0% -0.0% 108.12 KB 108.14 KB 34.64 KB 34.62 KB UMD_PROFILING
react-dom-unstable-fire.development.js 0.0% 0.0% 808.52 KB 808.85 KB 182.81 KB 182.86 KB NODE_DEV
react-dom-unstable-fire.production.min.js 0.0% 0.0% 105.11 KB 105.14 KB 33.49 KB 33.49 KB NODE_PROD
react-dom-unstable-fire.profiling.min.js 0.0% 0.0% 108.22 KB 108.24 KB 34.09 KB 34.09 KB NODE_PROFILING
ReactFire-dev.js 0.0% 0.0% 832.14 KB 832.46 KB 184.23 KB 184.29 KB FB_WWW_DEV
ReactFire-prod.js 🔺+0.1% 0.0% 320.04 KB 320.22 KB 58.71 KB 58.73 KB FB_WWW_PROD
ReactFire-profiling.js +0.1% 0.0% 326.37 KB 326.55 KB 60.06 KB 60.08 KB FB_WWW_PROFILING
react-dom-test-utils.development.js 0.0% -0.0% 47.49 KB 47.49 KB 12.98 KB 12.98 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.1% 9.95 KB 9.95 KB 3.66 KB 3.65 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 47.21 KB 47.21 KB 12.91 KB 12.91 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.1% 9.73 KB 9.73 KB 3.59 KB 3.58 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.74 KB 60.74 KB 15.84 KB 15.84 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.69 KB 10.69 KB 3.67 KB 3.66 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.41 KB 60.41 KB 15.72 KB 15.71 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.42 KB 10.42 KB 3.57 KB 3.56 KB NODE_PROD
react-dom-server.browser.development.js 0.0% -0.0% 134.78 KB 134.78 KB 35.51 KB 35.51 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.05 KB 19.05 KB 7.18 KB 7.18 KB UMD_PROD
react-dom-server.browser.development.js 0.0% -0.0% 130.91 KB 130.91 KB 34.57 KB 34.57 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 18.98 KB 18.98 KB 7.17 KB 7.17 KB NODE_PROD
ReactDOMServer-dev.js 0.0% -0.0% 133.22 KB 133.22 KB 34.32 KB 34.32 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 46.19 KB 46.19 KB 10.63 KB 10.62 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% -0.0% 132.86 KB 132.86 KB 35.12 KB 35.11 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 19.84 KB 19.84 KB 7.48 KB 7.48 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.66 KB 3.66 KB 1.45 KB 1.45 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.4% 1.21 KB 1.21 KB 708 B 705 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.2% 3.49 KB 3.49 KB 1.41 KB 1.41 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.6% 1.05 KB 1.05 KB 639 B 635 B NODE_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.2% 3.74 KB 3.74 KB 1.43 KB 1.43 KB NODE_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.6% 1.1 KB 1.1 KB 669 B 665 B NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% 0.0% 567 KB 567.33 KB 122.43 KB 122.49 KB UMD_DEV
react-art.production.min.js 0.0% 0.0% 96.78 KB 96.8 KB 29.68 KB 29.68 KB UMD_PROD
react-art.development.js +0.1% +0.1% 497.91 KB 498.24 KB 105.04 KB 105.09 KB NODE_DEV
react-art.production.min.js 0.0% 0.0% 61.78 KB 61.81 KB 18.91 KB 18.91 KB NODE_PROD
ReactART-dev.js +0.1% 0.0% 507.84 KB 508.16 KB 104.34 KB 104.39 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.1% 🔺+0.1% 196.63 KB 196.81 KB 33.3 KB 33.32 KB FB_WWW_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js 0.0% 0.0% 629 KB 629.31 KB 134.16 KB 134.21 KB RN_FB_DEV
ReactNativeRenderer-prod.js 0.0% 0.0% 246.02 KB 246.06 KB 43.02 KB 43.03 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 252.26 KB 252.31 KB 44.37 KB 44.38 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js 0.0% 0.0% 628.92 KB 629.23 KB 134.12 KB 134.18 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 0.0% 0.0% 246.03 KB 246.07 KB 43.02 KB 43.03 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 252.28 KB 252.33 KB 44.37 KB 44.38 KB RN_OSS_PROFILING
ReactFabric-dev.js +0.1% 0.0% 617.85 KB 618.17 KB 131.51 KB 131.57 KB RN_FB_DEV
ReactFabric-prod.js 0.0% 0.0% 239.42 KB 239.46 KB 41.76 KB 41.77 KB RN_FB_PROD
ReactFabric-profiling.js 0.0% 0.0% 244.76 KB 244.8 KB 43.08 KB 43.09 KB RN_FB_PROFILING
ReactFabric-dev.js +0.1% 0.0% 617.76 KB 618.07 KB 131.46 KB 131.52 KB RN_OSS_DEV
ReactFabric-prod.js 0.0% 0.0% 239.43 KB 239.47 KB 41.75 KB 41.76 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 244.77 KB 244.81 KB 43.08 KB 43.08 KB RN_OSS_PROFILING

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.1% +0.1% 509.45 KB 509.78 KB 107.21 KB 107.26 KB UMD_DEV
react-test-renderer.production.min.js 0.0% 0.0% 62.77 KB 62.79 KB 19.14 KB 19.14 KB UMD_PROD
react-test-renderer.development.js +0.1% +0.1% 504.97 KB 505.3 KB 106.05 KB 106.11 KB NODE_DEV
react-test-renderer.production.min.js 0.0% 0.0% 62.46 KB 62.48 KB 18.96 KB 18.97 KB NODE_PROD
ReactTestRenderer-dev.js +0.1% 0.0% 516.15 KB 516.46 KB 105.83 KB 105.87 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 38.98 KB 38.98 KB 9.81 KB 9.81 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.1% 11.42 KB 11.42 KB 3.51 KB 3.5 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% -0.0% 33.2 KB 33.2 KB 8.42 KB 8.41 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.1% 11.61 KB 11.61 KB 3.63 KB 3.63 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.1% +0.1% 498 KB 498.34 KB 103.88 KB 103.94 KB NODE_DEV
react-reconciler.production.min.js 0.0% 0.0% 62.97 KB 62.99 KB 18.73 KB 18.74 KB NODE_PROD
react-reconciler-persistent.development.js +0.1% +0.1% 495.89 KB 496.23 KB 103.02 KB 103.07 KB NODE_DEV
react-reconciler-persistent.production.min.js 0.0% 0.0% 62.98 KB 63 KB 18.74 KB 18.74 KB NODE_PROD
react-reconciler-reflection.development.js 0.0% -0.0% 15.79 KB 15.79 KB 4.91 KB 4.91 KB NODE_DEV
react-reconciler-reflection.production.min.js 0.0% -0.4% 2.37 KB 2.37 KB 1.07 KB 1.06 KB NODE_PROD

Generated by 🚫 dangerJS

@trueadm trueadm changed the title Add unwinding host context to EventComponents and EventTargets Fix host context issues around EventComponents and EventTargets Apr 1, 2019
@trueadm trueadm merged commit 4482fdd into facebook:master Apr 1, 2019
@trueadm trueadm deleted the unwind-event-api branch April 1, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

@threepointone threepointone Awaiting requested review from threepointone

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trueadm @sizebot @gaearon @facebook-github-bot