RFC Remove event pooling

src/browser/eventPlugins/BeforeInputEventPlugin.js

@@ -206,7 +206,7 @@ var BeforeInputEventPlugin = {
       return;
     }
 
-    var event = SyntheticInputEvent.getPooled(
+    var event = new SyntheticInputEvent(
       eventTypes.beforeInput,
       topLevelTargetID,
       nativeEvent

src/browser/eventPlugins/ChangeEventPlugin.js

@@ -77,7 +77,7 @@ if (ExecutionEnvironment.canUseDOM) {
 }
 
 function manualDispatchChangeEvent(nativeEvent) {
-  var event = SyntheticEvent.getPooled(
+  var event = new SyntheticEvent(
     eventTypes.change,
     activeElementID,
     nativeEvent
@@ -363,7 +363,7 @@ var ChangeEventPlugin = {
         topLevelTargetID
       );
       if (targetID) {
-        var event = SyntheticEvent.getPooled(
+        var event = new SyntheticEvent(
           eventTypes.change,
           targetID,
           nativeEvent

src/browser/eventPlugins/CompositionEventPlugin.js

@@ -245,7 +245,7 @@ var CompositionEventPlugin = {
     }
 
     if (eventType) {
-      var event = SyntheticCompositionEvent.getPooled(
+      var event = new SyntheticCompositionEvent(
         eventType,
         topLevelTargetID,
         nativeEvent

src/browser/eventPlugins/EnterLeaveEventPlugin.js

@@ -114,7 +114,7 @@ var EnterLeaveEventPlugin = {
     var fromID = from ? ReactMount.getID(from) : '';
     var toID = to ? ReactMount.getID(to) : '';
 
-    var leave = SyntheticMouseEvent.getPooled(
+    var leave = new SyntheticMouseEvent(
       eventTypes.mouseLeave,
       fromID,
       nativeEvent
@@ -123,7 +123,7 @@ var EnterLeaveEventPlugin = {
     leave.target = from;
     leave.relatedTarget = to;
 
-    var enter = SyntheticMouseEvent.getPooled(
+    var enter = new SyntheticMouseEvent(
       eventTypes.mouseEnter,
       toID,
       nativeEvent

src/browser/eventPlugins/ResponderEventPlugin.js

@@ -169,44 +169,38 @@ function setResponderAndExtractTransfer(
     eventTypes.scrollShouldSetResponder;
 
   var bubbleShouldSetFrom = responderID || topLevelTargetID;
-  var shouldSetEvent = SyntheticEvent.getPooled(
+  var shouldSetEvent = new SyntheticEvent(
     shouldSetEventType,
     bubbleShouldSetFrom,
     nativeEvent
   );
   EventPropagators.accumulateTwoPhaseDispatches(shouldSetEvent);
   var wantsResponderID = executeDispatchesInOrderStopAtTrue(shouldSetEvent);
-  if (!shouldSetEvent.isPersistent()) {
-    shouldSetEvent.constructor.release(shouldSetEvent);
-  }
 
   if (!wantsResponderID || wantsResponderID === responderID) {
     return null;
   }
   var extracted;
-  var grantEvent = SyntheticEvent.getPooled(
+  var grantEvent = new SyntheticEvent(
     eventTypes.responderGrant,
     wantsResponderID,
     nativeEvent
   );
 
   EventPropagators.accumulateDirectDispatches(grantEvent);
   if (responderID) {
-    var terminationRequestEvent = SyntheticEvent.getPooled(
+    var terminationRequestEvent = new SyntheticEvent(
       eventTypes.responderTerminationRequest,
       responderID,
       nativeEvent
     );
     EventPropagators.accumulateDirectDispatches(terminationRequestEvent);
     var shouldSwitch = !hasDispatches(terminationRequestEvent) ||
       executeDirectDispatch(terminationRequestEvent);
-    if (!terminationRequestEvent.isPersistent()) {
-      terminationRequestEvent.constructor.release(terminationRequestEvent);
-    }
 
     if (shouldSwitch) {
       var terminateType = eventTypes.responderTerminate;
-      var terminateEvent = SyntheticEvent.getPooled(
+      var terminateEvent = new SyntheticEvent(
         terminateType,
         responderID,
         nativeEvent
@@ -215,7 +209,7 @@ function setResponderAndExtractTransfer(
       extracted = accumulate(extracted, [grantEvent, terminateEvent]);
       responderID = wantsResponderID;
     } else {
-      var rejectEvent = SyntheticEvent.getPooled(
+      var rejectEvent = new SyntheticEvent(
         eventTypes.responderReject,
         wantsResponderID,
         nativeEvent
@@ -297,7 +291,7 @@ var ResponderEventPlugin = {
       isEndish(topLevelType) ? eventTypes.responderRelease :
       isStartish(topLevelType) ? eventTypes.responderStart : null;
     if (type) {
-      var gesture = SyntheticEvent.getPooled(
+      var gesture = new SyntheticEvent(
         type,
         responderID || '',
         nativeEvent

src/browser/eventPlugins/SelectEventPlugin.js

@@ -110,7 +110,7 @@ function constructSelectEvent(nativeEvent) {
   if (!lastSelection || !shallowEqual(lastSelection, currentSelection)) {
     lastSelection = currentSelection;
 
-    var syntheticEvent = SyntheticEvent.getPooled(
+    var syntheticEvent = new SyntheticEvent(
       eventTypes.select,
       activeElementID,
       nativeEvent

src/browser/eventPlugins/SimpleEventPlugin.js

@@ -405,8 +405,7 @@ var SimpleEventPlugin = {
       'SimpleEventPlugin: Unhandled event type, `%s`.',
       topLevelType
     );
-    var event = EventConstructor.getPooled(
-      dispatchConfig,
+    var event = new EventConstructor(dispatchConfig,
       topLevelTargetID,
       nativeEvent
     );

src/browser/eventPlugins/TapEventPlugin.js

@@ -113,7 +113,7 @@ var TapEventPlugin = {
     var event = null;
     var distance = getDistance(startCoords, nativeEvent);
     if (isEndish(topLevelType) && distance < tapMoveThreshold) {
-      event = SyntheticUIEvent.getPooled(
+      event = new SyntheticUIEvent(
         eventTypes.touchTap,
         topLevelTargetID,
         nativeEvent

src/browser/syntheticEvents/SyntheticEvent.js

@@ -19,8 +19,6 @@
 
 "use strict";
 
-var PooledClass = require('PooledClass');
-
 var emptyFunction = require('emptyFunction');
 var getEventTarget = require('getEventTarget');
 var merge = require('merge');
@@ -106,35 +104,6 @@ mergeInto(SyntheticEvent.prototype, {
     this.isPropagationStopped = emptyFunction.thatReturnsTrue;
   },
 
-  /**
-   * We release all dispatched `SyntheticEvent`s after each event loop, adding
-   * them back into the pool. This allows a way to hold onto a reference that
-   * won't be added back into the pool.
-   */
-  persist: function() {
-    this.isPersistent = emptyFunction.thatReturnsTrue;
-  },
-
-  /**
-   * Checks if this event should be released back into the pool.
-   *
-   * @return {boolean} True if this should not be released, false otherwise.
-   */
-  isPersistent: emptyFunction.thatReturnsFalse,
-
-  /**
-   * `PooledClass` looks for `destructor` on each instance it releases.
-   */
-  destructor: function() {
-    var Interface = this.constructor.Interface;
-    for (var propName in Interface) {
-      this[propName] = null;
-    }
-    this.dispatchConfig = null;
-    this.dispatchMarker = null;
-    this.nativeEvent = null;
-  }
-
 });
 
 SyntheticEvent.Interface = EventInterface;
@@ -155,10 +124,6 @@ SyntheticEvent.augmentClass = function(Class, Interface) {
 
   Class.Interface = merge(Super.Interface, Interface);
   Class.augmentClass = Super.augmentClass;
-
-  PooledClass.addPoolingTo(Class, PooledClass.threeArgumentPooler);
 };
 
-PooledClass.addPoolingTo(SyntheticEvent, PooledClass.threeArgumentPooler);
-
 module.exports = SyntheticEvent;

src/browser/syntheticEvents/__tests__/SyntheticEvent-test.js

@@ -27,7 +27,7 @@ describe('SyntheticEvent', function() {
     SyntheticEvent = require('SyntheticEvent');
 
     createEvent = function(nativeEvent) {
-      return SyntheticEvent.getPooled({}, '', nativeEvent);
+      return new SyntheticEvent({}, '', nativeEvent);
     };
   });
 
@@ -70,12 +70,4 @@ describe('SyntheticEvent', function() {
     expect(nativeEvent.cancelBubble).toBe(true);
   });
 
-  it('should be able to `persist`', function() {
-    var syntheticEvent = createEvent({});
-
-    expect(syntheticEvent.isPersistent()).toBe(false);
-    syntheticEvent.persist();
-    expect(syntheticEvent.isPersistent()).toBe(true);
-  });
-
 });

src/browser/syntheticEvents/__tests__/SyntheticWheelEvent-test.js

@@ -27,7 +27,7 @@ describe('SyntheticWheelEvent', function() {
     SyntheticWheelEvent = require('SyntheticWheelEvent');
 
     createEvent = function(nativeEvent) {
-      return SyntheticWheelEvent.getPooled({}, '', nativeEvent);
+      return new SyntheticWheelEvent({}, '', nativeEvent);
     };
   });
 
@@ -66,12 +66,4 @@ describe('SyntheticWheelEvent', function() {
     expect(syntheticEvent.isPropagationStopped()).toBe(true);
   });
 
-  it('should be able to `persist`', function() {
-    var syntheticEvent = createEvent({});
-
-    expect(syntheticEvent.isPersistent()).toBe(false);
-    syntheticEvent.persist();
-    expect(syntheticEvent.isPersistent()).toBe(true);
-  });
-
 });

src/event/EventPluginHub.js

@@ -53,10 +53,6 @@ var executeDispatchesAndRelease = function(event) {
       executeDispatch = PluginModule.executeDispatch;
     }
     EventPluginUtils.executeDispatchesInOrder(event, executeDispatch);
-
-    if (!event.isPersistent()) {
-      event.constructor.release(event);
-    }
   }
 };