From 01019aa7b4c07583e781fa2628aa069bfd49f845 Mon Sep 17 00:00:00 2001
From: Hristo Kanchev <hristokkanchev@gmail.com>
Date: Thu, 29 Aug 2019 10:22:38 +0200
Subject: [PATCH 1/3] Added anchor dom element in order to successfully
 download profiling data.

---
 .../devtools/views/Profiler/ProfilingImportExportButtons.js  | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/packages/react-devtools-shared/src/devtools/views/Profiler/ProfilingImportExportButtons.js b/packages/react-devtools-shared/src/devtools/views/Profiler/ProfilingImportExportButtons.js
index 376afcf45e883..8f6b40199ea2e 100644
--- a/packages/react-devtools-shared/src/devtools/views/Profiler/ProfilingImportExportButtons.js
+++ b/packages/react-devtools-shared/src/devtools/views/Profiler/ProfilingImportExportButtons.js
@@ -29,6 +29,7 @@ export default function ProfilingImportExportButtons() {
   const {profilerStore} = store;
 
   const inputRef = useRef<HTMLInputElement | null>(null);
+  const downloadRef = useRef<HTMLAnchorElement | null>(null);
 
   const {dispatch: modalDialogDispatch} = useContext(ModalDialogContext);
 
@@ -38,7 +39,7 @@ export default function ProfilingImportExportButtons() {
         return;
       }
 
-      if (profilingData !== null) {
+      if (profilingData !== null && downloadRef.current !== null) {
         const profilingDataExport = prepareProfilingDataExport(profilingData);
         const date = new Date();
         const dateString = date
@@ -54,6 +55,7 @@ export default function ProfilingImportExportButtons() {
           })
           .replace(/:/g, '-');
         downloadFile(
+          downloadRef.current,
           `profiling-data.${dateString}.${timeString}.json`,
           JSON.stringify(profilingDataExport, null, 2),
         );
@@ -114,6 +116,7 @@ export default function ProfilingImportExportButtons() {
         onChange={handleFiles}
         tabIndex={-1}
       />
+      <a ref={downloadRef} className={styles.Input} />
       <Button
         disabled={isProfiling}
         onClick={uploadData}

From cdbe738bfdbe330df16cb4238b2f63c2d7aeb957 Mon Sep 17 00:00:00 2001
From: Hristo Kanchev <hristokkanchev@gmail.com>
Date: Thu, 29 Aug 2019 10:23:27 +0200
Subject: [PATCH 2/3] Reworked downloadFile to accept a DOMElement in order for
 FF to successfully download profiling data.

---
 .../src/devtools/views/utils.js                     | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/packages/react-devtools-shared/src/devtools/views/utils.js b/packages/react-devtools-shared/src/devtools/views/utils.js
index 9ad71b5cd805a..ebd3d122bfc71 100644
--- a/packages/react-devtools-shared/src/devtools/views/utils.js
+++ b/packages/react-devtools-shared/src/devtools/views/utils.js
@@ -178,8 +178,12 @@ export function serializeHooksForCopy(hooks: HooksTree | null): string {
 // Without this, we would see a "Download failed: network error" failure.
 let downloadUrl = null;
 
-export function downloadFile(filename: string, text: string): void {
-  const blob = new Blob([text], {type: 'text/plain;charset=utf-8'});
+export function downloadFile(
+  element: HTMLAnchorElement,
+  filename: string,
+  text: string
+): void {
+  const blob = new Blob([text], { type: 'text/plain;charset=utf-8' });
 
   if (downloadUrl !== null) {
     URL.revokeObjectURL(downloadUrl);
@@ -187,15 +191,10 @@ export function downloadFile(filename: string, text: string): void {
 
   downloadUrl = URL.createObjectURL(blob);
 
-  const element = document.createElement('a');
   element.setAttribute('href', downloadUrl);
   element.setAttribute('download', filename);
-  element.style.display = 'none';
-  ((document.body: any): HTMLBodyElement).appendChild(element);
 
   element.click();
-
-  ((document.body: any): HTMLBodyElement).removeChild(element);
 }
 
 export function truncateText(text: string, maxLength: number): string {

From 1705e47c8d0f3750a66d0a69d11e9b72102f7265 Mon Sep 17 00:00:00 2001
From: Hristo Kanchev <hristokkanchev@gmail.com>
Date: Thu, 29 Aug 2019 18:08:13 +0200
Subject: [PATCH 3/3] Prettify downloadFile changes.

---
 packages/react-devtools-shared/src/devtools/views/utils.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/react-devtools-shared/src/devtools/views/utils.js b/packages/react-devtools-shared/src/devtools/views/utils.js
index ebd3d122bfc71..247f860ac6273 100644
--- a/packages/react-devtools-shared/src/devtools/views/utils.js
+++ b/packages/react-devtools-shared/src/devtools/views/utils.js
@@ -181,9 +181,9 @@ let downloadUrl = null;
 export function downloadFile(
   element: HTMLAnchorElement,
   filename: string,
-  text: string
+  text: string,
 ): void {
-  const blob = new Blob([text], { type: 'text/plain;charset=utf-8' });
+  const blob = new Blob([text], {type: 'text/plain;charset=utf-8'});
 
   if (downloadUrl !== null) {
     URL.revokeObjectURL(downloadUrl);