From ec5d128b171108f9648adb7a81dcc9fe64b242e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Chris=20L=C3=BCer?= Date: Wed, 5 Feb 2020 15:31:47 -0800 Subject: [PATCH 1/2] Move MS Windows build to CircleCI --- .circleci/config.yml | 51 +++++++++++++++++++++++++++++++++++++++++++- appveyor.yml | 41 ----------------------------------- 2 files changed, 50 insertions(+), 42 deletions(-) delete mode 100644 appveyor.yml diff --git a/.circleci/config.yml b/.circleci/config.yml index 584f8c111327e..467fd4d39eb0d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1,4 +1,7 @@ -version: 2 +version: 2.1 + +orbs: + win: circleci/windows@2.4.0 aliases: - &docker @@ -48,6 +51,9 @@ aliases: paths: - bundle-sizes.json + - &ms_windows_environment + JAVA_HOME: C:\Program Files\Java\jdk1.8.0 + jobs: setup: docker: *docker @@ -352,6 +358,43 @@ jobs: RELEASE_CHANNEL: experimental command: yarn test-build-prod --maxWorkers=2 + test_ms_windows: + executor: + name: win/default + environment: *ms_windows_environment + steps: + - run: + # Fix line endings in Windows. + command: git config --global core.autocrlf input + - checkout + - restore_cache: + keys: + - v2-win-node-{{ arch }}-{{ .Branch }}-{{ checksum "yarn.lock" }} + - v2-win-node-{{ arch }}-{{ .Branch }}- + - v2-win-node-{{ arch }}- + - run: + command: nvm install 10.18.1 + - run: + command: nvm use 10.18.1 + - run: + command: node --version + - run: + command: choco install yarn + - run: + command: yarn install --frozen-lockfile + - save_cache: + key: v2-win-node-{{ arch }}-{{ .Branch }}-{{ checksum "yarn.lock" }} + paths: + - C:\Users\circleci\AppData\Local\Yarn + - run: + command: yarn lint + - run: + command: yarn build + - run: + command: yarn test + - run: + command: yarn prettier + workflows: version: 2 stable: @@ -439,3 +482,9 @@ workflows: - test_fuzz: requires: - setup + + ms_windows: + jobs: + - test_ms_windows + + diff --git a/appveyor.yml b/appveyor.yml deleted file mode 100644 index 8191e610a95ff..0000000000000 --- a/appveyor.yml +++ /dev/null @@ -1,41 +0,0 @@ -image: Visual Studio 2017 - -# Fix line endings in Windows. (runs before repo cloning) -init: - - git config --global core.autocrlf input - -environment: - JAVA_HOME: C:\Program Files\Java\jdk1.8.0 - matrix: - - nodejs_version: 10 - -# Finish on first failed build -matrix: - fast_finish: true - -platform: - - x64 - -branches: - only: - - master - -# Disable Visual Studio build and deploy -build: off -deploy: off - -install: - - ps: Install-Product node $env:nodejs_version $env:platform - - yarn install --frozen-lockfile - -test_script: - - node --version - - yarn lint -# - yarn flow-ci - - yarn build - - yarn test - - yarn prettier - -cache: - - node_modules - - "%LOCALAPPDATA%/Yarn" From a09d7cd627d92898795b020a24c183850d3dcb2e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Chris=20L=C3=BCer?= Date: Thu, 6 Feb 2020 15:30:06 -0800 Subject: [PATCH 2/2] Update to latest NodeJS --- .circleci/config.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 467fd4d39eb0d..c7ba1b6b1e7c5 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -372,16 +372,11 @@ jobs: - v2-win-node-{{ arch }}-{{ .Branch }}-{{ checksum "yarn.lock" }} - v2-win-node-{{ arch }}-{{ .Branch }}- - v2-win-node-{{ arch }}- - - run: - command: nvm install 10.18.1 - - run: - command: nvm use 10.18.1 - run: command: node --version - run: command: choco install yarn - - run: - command: yarn install --frozen-lockfile + - *run_yarn - save_cache: key: v2-win-node-{{ arch }}-{{ .Branch }}-{{ checksum "yarn.lock" }} paths: