Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixture: Legacy JSX Runtimes #20012

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Fixture: Legacy JSX Runtimes #20012

merged 2 commits into from
Oct 14, 2020

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Oct 13, 2020

Adds checked-in bundles for JSX runtimes for different stable React versions. Those were edited by hand.
Each comes with an integration testing suite adjusted for that version.

They look like this:

Screenshot 2020-10-14 at 00 16 37

cd fixtures/legacy-jsx-runtimes 
yarn
yarn test

Screenshot 2020-10-14 at 00 17 23

The regression suite contains a lint step and some hand-picked tests adapted from different existing ones in the repo. We run in three configurations: jsxDEV in DEV, jsx in DEV, and jsx in PROD.

Differences Between Bundles

Each lower bundle is based on the higher one.

  • 16: Use old stacks. Remove object-assign from the output.
  • 15: Read old stacks from ReactComponentTreeHook.
  • 14: Remove stacks. Use instance.getName() in messages. Read ReactCurrentOwner from react/lib/.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a58529b:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Oct 13, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against a58529b

@sizebot
Copy link

sizebot commented Oct 13, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against a58529b

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 14, 2020
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!!

@gaearon gaearon merged commit 6d50a9d into facebook:master Oct 14, 2020
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
* Fixture: Legacy JSX Runtimes

* Add more comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants