From 9134ea9693905e817845374be6fa285a150feca8 Mon Sep 17 00:00:00 2001 From: Jack Pope Date: Thu, 15 Feb 2024 10:10:17 -0500 Subject: [PATCH 1/3] Add useModernStrictMode as dynamic flag on www --- packages/shared/forks/ReactFeatureFlags.www-dynamic.js | 1 + packages/shared/forks/ReactFeatureFlags.www.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/shared/forks/ReactFeatureFlags.www-dynamic.js b/packages/shared/forks/ReactFeatureFlags.www-dynamic.js index a8c873d93b86e..b97a52e52a56e 100644 --- a/packages/shared/forks/ReactFeatureFlags.www-dynamic.js +++ b/packages/shared/forks/ReactFeatureFlags.www-dynamic.js @@ -28,6 +28,7 @@ export const alwaysThrottleRetries = __VARIANT__; export const enableDO_NOT_USE_disableStrictPassiveEffect = __VARIANT__; export const enableUseDeferredValueInitialArg = __VARIANT__; export const enableRenderableContext = __VARIANT__; +export const useModernStrictMode = __VARIANT__; export const enableRetryLaneExpiration = __VARIANT__; export const retryLaneExpirationMs = 5000; diff --git a/packages/shared/forks/ReactFeatureFlags.www.js b/packages/shared/forks/ReactFeatureFlags.www.js index 2bfba8c3a858f..0a18e4300be43 100644 --- a/packages/shared/forks/ReactFeatureFlags.www.js +++ b/packages/shared/forks/ReactFeatureFlags.www.js @@ -36,6 +36,7 @@ export const { transitionLaneExpirationMs, enableInfiniteRenderLoopDetection, enableRenderableContext, + useModernStrictMode, } = dynamicFeatureFlags; // On WWW, __EXPERIMENTAL__ is used for a new modern build. @@ -103,7 +104,6 @@ export const allowConcurrentByDefault = true; export const consoleManagedByDevToolsDuringStrictMode = true; -export const useModernStrictMode = false; export const enableFizzExternalRuntime = true; export const forceConcurrentByDefaultForTesting = false; From e35e69ab06dae78b95d049dbdef419532fdbd92d Mon Sep 17 00:00:00 2001 From: Jack Pope Date: Thu, 15 Feb 2024 10:57:44 -0500 Subject: [PATCH 2/3] force rebuild --- packages/shared/forks/ReactFeatureFlags.www.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/shared/forks/ReactFeatureFlags.www.js b/packages/shared/forks/ReactFeatureFlags.www.js index 0a18e4300be43..b6de93930728a 100644 --- a/packages/shared/forks/ReactFeatureFlags.www.js +++ b/packages/shared/forks/ReactFeatureFlags.www.js @@ -40,7 +40,7 @@ export const { } = dynamicFeatureFlags; // On WWW, __EXPERIMENTAL__ is used for a new modern build. -// It's not used anywhere in production yet. +// It's not used anywhere in production yet.. export const debugRenderPhaseSideEffectsForStrictMode = __DEV__; export const enableProfilerTimer = __PROFILE__; From 37a5656b667bd4d5c9a59ab5683bb27e5b25e68d Mon Sep 17 00:00:00 2001 From: Jack Pope Date: Thu, 15 Feb 2024 10:57:55 -0500 Subject: [PATCH 3/3] f --- packages/shared/forks/ReactFeatureFlags.www.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/shared/forks/ReactFeatureFlags.www.js b/packages/shared/forks/ReactFeatureFlags.www.js index b6de93930728a..0a18e4300be43 100644 --- a/packages/shared/forks/ReactFeatureFlags.www.js +++ b/packages/shared/forks/ReactFeatureFlags.www.js @@ -40,7 +40,7 @@ export const { } = dynamicFeatureFlags; // On WWW, __EXPERIMENTAL__ is used for a new modern build. -// It's not used anywhere in production yet.. +// It's not used anywhere in production yet. export const debugRenderPhaseSideEffectsForStrictMode = __DEV__; export const enableProfilerTimer = __PROFILE__;