Warn for useFormState on initial render #30292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
acdlite
approved these changes
Jul 8, 2024
sebmarkbage
force-pushed
the
fixformwarning
branch
from
f33bb61
to
f6f9190
Compare
sebmarkbage
force-pushed
the
fixformwarning
branch
2 times, most recently
from
90bd5d2
to
31d53ea
Compare
sebmarkbage
force-pushed
the
fixformwarning
branch
from
31d53ea
to
fbbf8bd
Compare
sebmarkbage
commented
Jul 8, 2024
|
|
||
| import Container from './Container.js'; | ||
|
|
||
| export function Counter({incrementAction}) { | ||
| const [count, incrementFormAction] = useFormState(incrementAction, 0); |
There was a problem hiding this comment.
I've been using this to test the warning - that's how I found this bug. Didn't realize that the fixture test was actually supposed to error on this. :P
sebmarkbage
force-pushed
the
fixformwarning
branch
from
fbbf8bd
to
162829b
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
This was missed in the mount dev dispatcher. It was only in the rerender dispatcher which means that it was only logged during the rerender. Since DevTools can hide logs during rerenders, this hid the warning in StrictMode. DiffTrain build for commit 274c980.
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in the mount dev dispatcher. It was only in the rerender dispatcher which means that it was only logged during the rerender. Since DevTools can hide logs during rerenders, this hid the warning in StrictMode.