Remove enableRefAsProp feature flag #30346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
kassens
commented
Jul 16, 2024
jackpope
approved these changes
Jul 16, 2024
Comment on lines
211
to
215
| // When enableRefAsProp is on, ignore whatever was passed as the ref | ||
| // argument and treat `props.ref` as the source of truth. The only thing we | ||
| // use this for is `element.ref`, which will log a deprecation warning on | ||
| // access. In the next release, we can remove `element.ref` as well as the | ||
| // `ref` argument. |
There was a problem hiding this comment.
This comment should be updated to remove reference to the flag that no longer exists. Looks like element.ref is still provided below, but the flag and argument are removed in this PR.
packages/react-devtools-shared/src/__tests__/legacy/storeLegacy-v15-test.js
Outdated
Show resolved
Hide resolved
**NOTE:** To be merged after React 19 is released. The flag is fully rolled out.
kassens
added a commit
to kassens/react
that referenced
this pull request
Nov 4, 2024
I missed that this was a constant false check when making the broader cleanup changes in facebook#30346
kassens
added a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag is fully rolled out.