Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Delete propagateScopeDeps (non-hir) #31199

Merged
merged 1 commit into from
Nov 6, 2024
Merged

[compiler] Delete propagateScopeDeps (non-hir) #31199

merged 1 commit into from
Nov 6, 2024

Commits on Nov 5, 2024

  1. [compiler] Delete propagateScopeDeps (non-hir)

    `enablePropagateScopeDepsHIR` is now used extensively in Meta. This has been tested for over two weeks in our e2e tests and production.
    
    The rest of this stack deletes `LoweredFunction.dependencies`, which the non-hir version of `PropagateScopeDeps` depends on. To avoid a more forked HIR (non-hir with dependencies and hir with no dependencies), let's go ahead and clean up the non-hir version of PropagateScopeDepsHIR.
    
    Note that all fixture changes in this PR were previously reviewed when they were copied to `propagate-scope-deps-hir-fork`. Will clean up / merge these duplicate fixtures in a later PR
    
    '
    mofeiZ committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    1b21452 View commit details
    Browse the repository at this point in the history