Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Gulp conversion #7172

Closed
wants to merge 17 commits into from
Closed

[WIP] Gulp conversion #7172

wants to merge 17 commits into from

Conversation

maxdeviant
Copy link
Contributor

@maxdeviant maxdeviant commented Jul 2, 2016

Starting work on converting the build process/tooling from Grunt to Gulp, which would resolve #4927 and is relevant to #6656.

Progress

  • gulp lint
  • gulp flow
  • gulp version-check
  • gulp build
    • gulp build:react-dom
  • gulp release
  • ???

I think we should keep the tasks in separate files, as I think this makes things more manageable than one giant gulpfile. Regardless, it would be trival to combine them back into one file, if desired.

@zpao Would you like to do the conversion in one fell swoop? Or would it be better to merge smaller PRs to slowly convert to Gulp?

A temporary measure to keep CI passing while using a combo of Gulp and
Grunt tasks.
Leaving the Grunt one in place, since it is consumed by Grunt tasks
that have yet to be ported.
Added the previously removed grunt tasks and just have them call the
gulp tasks.

This keeps things backwards-compatible, while still allowing for the
gulp migration.

Also reverted the changes to Travis CI, so hopefully there should be no
issues there.
@sebmarkbage
Copy link
Collaborator

Beware that this is a moving target and I'd like to land these first: #7164 #7168

@maxdeviant
Copy link
Contributor Author

maxdeviant commented Jul 2, 2016

@sebmarkbage Noted. Hence why I think breaking the conversion up into smaller PRs might be easier 😄

I'll keep an eye on those and see about reconciling against them when they are merged.

@maxdeviant
Copy link
Contributor Author

Closing this in favor of #7174 and subsequent PRs to cover smaller chunks of the work.

@maxdeviant maxdeviant closed this Jul 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch entirely to gulp
3 participants