-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Gulp conversion #7172
Closed
Closed
[WIP] Gulp conversion #7172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A temporary measure to keep CI passing while using a combo of Gulp and Grunt tasks.
Leaving the Grunt one in place, since it is consumed by Grunt tasks that have yet to be ported.
Added the previously removed grunt tasks and just have them call the gulp tasks. This keeps things backwards-compatible, while still allowing for the gulp migration. Also reverted the changes to Travis CI, so hopefully there should be no issues there.
@sebmarkbage Noted. Hence why I think breaking the conversion up into smaller PRs might be easier 😄 I'll keep an eye on those and see about reconciling against them when they are merged. |
4 tasks
Closing this in favor of #7174 and subsequent PRs to cover smaller chunks of the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting work on converting the build process/tooling from Grunt to Gulp, which would resolve #4927 and is relevant to #6656.
Progress
gulp lint
gulp flow
gulp version-check
gulp build
gulp build:react-dom
gulp release
I think we should keep the tasks in separate files, as I think this makes things more manageable than one giant gulpfile. Regardless, it would be trival to combine them back into one file, if desired.
@zpao Would you like to do the conversion in one fell swoop? Or would it be better to merge smaller PRs to slowly convert to Gulp?