Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shallow rendering: create node mock #8592

Closed
wants to merge 7 commits into from
Closed

shallow rendering: create node mock #8592

wants to merge 7 commits into from

Conversation

charlierudolph
Copy link

@charlierudolph charlierudolph commented Dec 17, 2016

Following in the footsteps of #7649 and #8261, bringing createNodeMock to shallow rendering so enzyme's shallow rendering (enzymejs/enzyme#721) can make use of it.

Currently this breaks the unit test related to shallow rendering and the legacy ref api. Any suggestions about what to do in that case?

@charlierudolph
Copy link
Author

@bvaughn @aweary could either of you please help / review or know who would be a good person who could?

@tauren
Copy link

tauren commented Jan 28, 2017

would love to see this land

@gaearon
Copy link
Collaborator

gaearon commented Apr 21, 2017

Thanks for the PR. I don’t think we’ll proceed with this. I’m sorry we didn’t review this before: we’re in the middle of rewriting React, and there is a lot of churn. In the end @bvaughn has completely rewritten shallow renderer so this no longer merges.

We’ll need to think about shallow rendering and refs in the longer term so feel free to raise an issue with discussion. The way shallow rendering currently works with refs and lifecycles is confusing (e.g. it doesn’t call didMount but calls didUpdate).

Again, sorry this slipped through the cracks.

@gaearon gaearon closed this Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants