option to modify/process props while passing down to component from HOC(container) ?

[chandu0101]

is it good idea to support this feature ?

UseCase : I am using relay in scala.js app , i want to pass type safe classes to the component ( instead of manually deserializing json to scala classes every time i call props).

Pseudo code :

relay/src/container/RelayContainer.js

Line 783 in 5e77de5

<Component

var finalStateProps =  {...this.state.queryData}

 if(spec.processProps)  {
   finalProps = spec.processProps( {...this.state.queryData})
 }

<Component {...this.props}
          {...finalStateProps}
          {...prepareRelayContainerProps(relayProps, this)}
          ref="component" />

or process all pieces ({this.props,this.state.queryData,ref,relayprops})

[xsistens]

👍

[Globegitter]

Something that would be useful for us as well in certain use-cases. E.g. we query the same data all over our app, but in a few parts we need to prepare the data, e.g. to display it in our select-component.

[chandu0101]

any objections for this proposal ? please let me know if none i'll send a PR!

[josephsavona]

I'm a bit wary of adding more complexity to RelayContainer. What are you doing as a workaround?

[Globegitter]

The current workaround that we are using is modifying the data in the render function (e.g. before we pass it down into a generic component).

[kassens]

It appears to me that this is a fine workaround and doesn't add much boilerplate to your app and if common in your case could be moved into a higher order component or some other abstraction.

I'm with @josephsavona on this one that we should try to keep the API small.