Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot resolve module 'qs' and 'deep-equal' in react-router #439

Closed
octref opened this issue Oct 8, 2015 · 5 comments
Closed

Cannot resolve module 'qs' and 'deep-equal' in react-router #439

octref opened this issue Oct 8, 2015 · 5 comments

Comments

@octref
Copy link
Contributor

octref commented Oct 8, 2015

Fresh clone. For the todo example, run npm i and npm start. Here is the error message:

  [761] ./js/queries/ViewerQueries.js 995 bytes {0} [built]

ERROR in ./~/react-router/~/history/lib/useQueries.js
Module not found: Error: Cannot resolve module 'qs' in /Users/octref/Code/learn/relay/relay/examples/todo/node_modules/react-router/node_modules/history/lib
 @ ./~/react-router/~/history/lib/useQueries.js 11:10-23

ERROR in ./~/react-router/~/history/lib/createHistory.js
Module not found: Error: Cannot resolve module 'deep-equal' in /Users/octref/Code/learn/relay/relay/examples/todo/node_modules/react-router/node_modules/history/lib
 @ ./~/react-router/~/history/lib/createHistory.js 13:17-38
webpack: bundle is now VALID.

Manually installing qs and deep-equal solve the problem. But I guess that's not the way the problem should be resolved.

I'm using Node v4.1.2 and npm 2.14.4 if that matters.

@josephsavona
Copy link
Contributor

@octref These are dependencies of react-router, not Relay. I'd recommend filing an issue with react-router. Feel free to comment again here though if that doesn't solve the problem!

@octref
Copy link
Contributor Author

octref commented Oct 8, 2015

Yeah the problem is remix-run/react-router#2195. They are saying rc3 will be released soon and it'll solve the problem. Should I keep an eye on it and submit a PR to update the dependencies for relay examples?

@josephsavona
Copy link
Contributor

@octref that would be great, thanks!

@kassens
Copy link
Member

kassens commented Oct 8, 2015

@octref: rc3 is released now. Want to send the PR for the fix?

@octref
Copy link
Contributor Author

octref commented Oct 8, 2015

@kassens
Done and signed CLA.

@ghost ghost closed this as completed in c675918 Oct 8, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants