Stop flattening/refragmenting queries #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsavona
force-pushed
the
noflattenorrefragment
branch
3 times, most recently
from
7942a2f to
1c4312d
Compare
josephsavona
force-pushed
the
noflattenorrefragment
branch
from
1c4312d to
62494dc
Compare
| @@ -66,6 +66,7 @@ var toGraphQL = { | |||
| isDeferred: node.isDeferred(), | |||
| metadata: node.__concreteNode__.metadata, | |||
| name: node.getName(), | |||
| type: node.getType(), | |||
There was a problem hiding this comment.
Isn't a corresponding change in fromGraphQL needed?
There was a problem hiding this comment.
No, that uses the concrete object which has type.
This was referenced May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the flattening/refragmenting of tracked queries and synthesized mutations, as well as addressing #596.